54668 - mNextDependeeIdx is not initialized in nsComponent.cpp

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Jim Dunn]

mozilla/xpinstall/wizard/unix/src2/nsComponent.cpp

It turns out the member variable for the array index is
NOT initialized to 0.  While some compilers/OS's might automatically
default, this behavior is NOT guarenteed.

Comment 1

[Jim Dunn]

Here is a sample diff.

Index: nsComponent.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpinstall/wizard/unix/src2/nsComponent.cpp,v
retrieving revision 1.4
diff -c -r1.4 nsComponent.cpp
*** nsComponent.cpp     2000/05/10 22:44:48     1.4
--- nsComponent.cpp     2000/09/29 13:27:47
***************
*** 41,46 ****
--- 41,48 ----
          mURL[i] = NULL;
      for (i = 0; i < MAX_COMPONENTS; i++)
          mDependees[i] = NULL;
+
+     mNextDependeeIdx = 0;
  }

  nsComponent::~nsComponent()
***************
*** 54,59 ****
--- 56,63 ----
          XI_IF_FREE(mURL[i]);
      for (i = 0; i < MAX_COMPONENTS; i++)
          XI_IF_FREE(mDependees[i]);
+
+     mNextDependeeIdx = 0;
  }

  nsComponent *

Comment 2

[Sean Su]

reassigning to Samir.

Comment 3

[Samir Gehani]

Ummm, sure, r=sgehani.

Comment 4

[Daniel Veditz [:dveditz]]

Reassigning per earlier comment, or Jim can check it in.

Comment 5

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 6

[Scott MacGregor]

sr=mscott

Comment 7

[Samir Gehani]

Fix checked in.

Comment 8

[Grace Bush]

verified code fix