Last Comment Bug 546719 - When reopening a Resolved Duplicated bug in IE, JS error stops the correct page behavior
: When reopening a Resolved Duplicated bug in IE, JS error stops the correct pa...
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: User Interface (show other bugs)
: 3.4.4
: All All
: -- major with 1 vote (vote)
: Bugzilla 3.4
Assigned To: Guy Pyrzak
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-17 12:14 PST by Liya
Modified: 2010-02-18 10:59 PST (History)
2 users (show)
mkanat: approval+
mkanat: approval3.6+
LpSolit: blocking3.6+
mkanat: approval3.4+
LpSolit: blocking3.4.6+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
JS error (92.76 KB, image/tiff)
2010-02-17 12:15 PST, Liya
no flags Details
patch v1 (747 bytes, patch)
2010-02-17 12:59 PST, Guy Pyrzak
mkanat: review+
Details | Diff | Splinter Review

Description Liya 2010-02-17 12:14:33 PST
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 GTB6
Build Identifier: 

Reproducible in IE7 and IE8, didn't try older ones
Can not be reproduced in FF at all (no errors in the error console)

Looks like the problem comes from field.js - fails to hide the "dupl" items - see the attached screenshot of the error

Reproducible: Always

Steps to Reproduce:
1. Open a bug in status RESOLVED DUPLICATED in IE
2. Change status to REOPENED


Actual Results:  
JS error appears
Comment 1 Liya 2010-02-17 12:15:20 PST
Created attachment 427397 [details]
JS error
Comment 2 Guy Pyrzak 2010-02-17 12:59:09 PST
Created attachment 427415 [details] [diff] [review]
patch v1
Comment 3 Max Kanat-Alexander 2010-02-17 13:05:07 PST
Comment on attachment 427415 [details] [diff] [review]
patch v1

Why would dup_id itself specifically have the bz_default_hidden class on it?
Comment 4 Guy Pyrzak 2010-02-17 13:14:00 PST
Comment on attachment 427415 [details] [diff] [review]
patch v1

nevermind. It looks like this will fix one of many errors that happen with IE and the dup stuff. I'll continue working this though
Comment 5 Guy Pyrzak 2010-02-17 13:21:42 PST
Comment on attachment 427415 [details] [diff] [review]
patch v1

nevermind. That patch did work perfectly.
Comment 6 Guy Pyrzak 2010-02-17 13:29:03 PST
it is added by the line

hideEditableField( "dup_id_container", "dup_id", 'dup_id_edit_action',
                     'dup_id', '2' )

which is part of the template code.
Comment 7 Max Kanat-Alexander 2010-02-17 13:46:19 PST
Comment on attachment 427415 [details] [diff] [review]
patch v1

Ah, okay. This looks OK, then. But shouldn't this script actually just be unhiding that directly? Perhaps I don't understand something or I'm just not looking at something.
Comment 8 Guy Pyrzak 2010-02-17 13:58:48 PST
so what's happening (it does this in firefox too) is that the function (showDuplicateItem) gets called too often it seems. 

The first time the function gets called the value is set to "resolved" but since no one has clicked edit the input box is hidden (behind the edit text). The next time the function (showDuplicateItem) is called the value is updated to the current value and all is happy.

The problem with IE7 and 8 is since the function call errors out it never gets to the 2nd call and then the whole thing gets foobared.
Comment 9 Frédéric Buclin 2010-02-18 10:59:14 PST
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified js/field.js
Committed revision 7005.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified js/field.js
Committed revision 6983.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.4/
modified js/field.js
Committed revision 6728.

Note You need to log in before you can comment on or make changes to this bug.