When reopening a Resolved Duplicated bug in IE, JS error stops the correct page behavior

RESOLVED FIXED in Bugzilla 3.4



10 years ago
10 years ago


(Reporter: liya, Assigned: guy.pyrzak)


Bugzilla 3.4
Bug Flags:
approval +
approval3.6 +
blocking3.6 +
approval3.4 +
blocking3.4.6 +



(2 attachments)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 GTB6
Build Identifier: 

Reproducible in IE7 and IE8, didn't try older ones
Can not be reproduced in FF at all (no errors in the error console)

Looks like the problem comes from field.js - fails to hide the "dupl" items - see the attached screenshot of the error

Reproducible: Always

Steps to Reproduce:
1. Open a bug in status RESOLVED DUPLICATED in IE
2. Change status to REOPENED

Actual Results:  
JS error appears
Posted image JS error
Ever confirmed: true
Hardware: x86 → All
Posted patch patch v1Splinter Review
Attachment #427415 - Flags: review?(mkanat)
Attachment #427415 - Flags: review?(LpSolit)
Comment on attachment 427415 [details] [diff] [review]
patch v1

Why would dup_id itself specifically have the bz_default_hidden class on it?
Comment on attachment 427415 [details] [diff] [review]
patch v1

nevermind. It looks like this will fix one of many errors that happen with IE and the dup stuff. I'll continue working this though
Attachment #427415 - Attachment is obsolete: true
Attachment #427415 - Flags: review?(mkanat)
Attachment #427415 - Flags: review?(LpSolit)
Comment on attachment 427415 [details] [diff] [review]
patch v1

nevermind. That patch did work perfectly.
Attachment #427415 - Attachment is obsolete: false
Attachment #427415 - Flags: review?(mkanat)
Version: unspecified → 3.4.4
it is added by the line

hideEditableField( "dup_id_container", "dup_id", 'dup_id_edit_action',
                     'dup_id', '2' )

which is part of the template code.
Comment on attachment 427415 [details] [diff] [review]
patch v1

Ah, okay. This looks OK, then. But shouldn't this script actually just be unhiding that directly? Perhaps I don't understand something or I'm just not looking at something.
Attachment #427415 - Flags: review?(mkanat) → review+
Flags: approval3.6+
Flags: approval3.4+
Flags: approval+
Target Milestone: --- → Bugzilla 3.4
Assignee: ui → guy.pyrzak
Flags: blocking3.6+
Flags: blocking3.4.6+
so what's happening (it does this in firefox too) is that the function (showDuplicateItem) gets called too often it seems. 

The first time the function gets called the value is set to "resolved" but since no one has clicked edit the input box is hidden (behind the edit text). The next time the function (showDuplicateItem) is called the value is updated to the current value and all is happy.

The problem with IE7 and 8 is since the function call errors out it never gets to the 2nd call and then the whole thing gets foobared.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified js/field.js
Committed revision 7005.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified js/field.js
Committed revision 6983.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.4/
modified js/field.js
Committed revision 6728.
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.