Closed Bug 546936 Opened 10 years ago Closed 10 years ago

Adapt Help for changes from Bug 536374 - Places history changes due to async expiration

Categories

(SeaMonkey :: Help Documentation, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: InvisibleSmiley, Assigned: kairo)

References

Details

Attachments

(1 file, 1 obsolete file)

From Bug 536374 comment 22:
"Also I suggest adding a relnote explaining people that the old prefs allowed for making some false assumptions (e.g. only the minimum number of days to keep history could be set effectively since the upper bound really was determined by the maximum number of pages to keep). Cf. MaK's blog post:
<http://blog.bonardo.net/2010/01/20/places-got-async-expiration>"
Argh, sorry about forgetting the help changes, I knew there was something I had this marked TODO for...
(In reply to comment #1)
> Argh, sorry about forgetting the help changes, I knew there was something I had
> this marked TODO for...

You may still want to set the Target Milestone (I refrained from doing it myself since you're the assignee).
Assignee: nobody → kairo
Target Milestone: --- → seamonkey2.1a1
Attached patch adapt help for history prefs (obsolete) — Splinter Review
So this one is easy :)
Attachment #437959 - Flags: review?(iann_bugzilla)
Oops, I found one more stance that becomes obsolete with this.
Attachment #437959 - Attachment is obsolete: true
Attachment #437968 - Flags: review?(iann_bugzilla)
Attachment #437959 - Flags: review?(iann_bugzilla)
Status: NEW → ASSIGNED
Comment on attachment 437968 [details] [diff] [review]
adapt help for history prefs a bit more

>+++ b/suite/locales/en-US/chrome/common/help/cs_nav_prefs_navigator.xhtml
>@@ -144,35 +144,20 @@
>+      <li><strong>Remember visited pages</strong>: Select this to make
>+        &brandShortName; remember pages you visit in the browsing history.
"within" instead of "in" perhaps?
 You
>+        need that for example to be able to search for pages you have already
>+        visited from the location bar or history window.</li>
Use "For example, you need this to be able to..."

>diff --git a/suite/locales/en-US/chrome/common/help/nav_help.xhtml b/suite/locales/en-US/chrome/common/help/nav_help.xhtml
>--- a/suite/locales/en-US/chrome/common/help/nav_help.xhtml
>+++ b/suite/locales/en-US/chrome/common/help/nav_help.xhtml
>@@ -218,20 +218,16 @@
>     <span class="mac">&brandShortName;</span><span class="noMac">Edit</span>
>     menu and choose Preferences.</li>
>   <li>Under the Browser category, click History. (If no subcategories are
>     visible, double-click Browser to expand the list.)</li>
>   <li>Click Clear History and Clear Location Bar to remove all previously
>     visited web pages from the lists.</li>
> </ol>
> 
>-<p><strong>Tip</strong>: Use the preferences under <a
>-  href="cs_nav_prefs_navigator.xhtml#history">Browsing History</a> to set
>-  how long and how many pages will remain in the history list.</p>
>-
Rather than deleting should the tip just be changed to:
"Use the preference under Browsing History to set if the history of visited pages is remembered."

r- for the moment.
Attachment #437968 - Flags: review?(iann_bugzilla) → review-
(In reply to comment #5)
> Rather than deleting should the tip just be changed to:
> "Use the preference under Browsing History to set if the history of visited
> pages is remembered."

Actually, that "tip" doesn't sound really helpful to me. It's only and on/off switch now anyhow, and this is in "About History Lists" - do people reading that really want to know how to turn off having content in one of those lists at all?
Whiteboard: [history]
(In reply to comment #6)
> (In reply to comment #5)
> > Rather than deleting should the tip just be changed to:
> > "Use the preference under Browsing History to set if the history of visited
> > pages is remembered."
> 
> Actually, that "tip" doesn't sound really helpful to me. It's only and on/off
> switch now anyhow, and this is in "About History Lists" - do people reading
> that really want to know how to turn off having content in one of those lists
> at all?

okay, so leave the deletion of the tip in then.
Comment on attachment 437968 [details] [diff] [review]
adapt help for history prefs a bit more

r=me with those first 2 changes.
Attachment #437968 - Flags: review- → review+
Pushed as http://hg.mozilla.org/comm-central/rev/6d1782409f38
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [history]
You need to log in before you can comment on or make changes to this bug.