546943 - Don't display drop shadows when dragging back to original date

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Followup bug from bug 476227.


STR:

1. Create a Multi-Day event
2. Switch to Month view
3. Start dragging this event to a different date, but don't drop
4. Drag the event back to the exact date it came from

Actual:

* Both the drop shadow and the event is shown, adjacent to each other.


Expected:

* After Step 4, the drag shadow should disappear, until you drag the event somewhere else again.

Comment 1

[Decathlon]

Attachment: patch

With this patch the behavior is as request (even when the drag starts, i.e. the shadow aren't showed until the cursor goes outside the initial day box).

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 428653 [details] [diff] [review]
patch

This patch doesn't quite work for me:

1. Create a two day event from 11th - 12th
2. Click to drag the event box on the 11th
3. Drag the box to the 10th
--> OK: Dropshadows appear
4. Drag the box back to the 11th
---> NOT OK: Dropshadow stays on 10th-11th.
5. Drop the event on the 11th
---> OK: The event does drop at the right position

Same happens the other way around, i.e moving to the 12th and back.

Comment 3

[Decathlon]

Attachment: avoid bug 502438

Is it possible you've stumbled on bug 502438? Maybe you can also confirm that one if it's the case.
I came across that bug during test for bug 476227. After that checkin, the bug 502438 has changed, so I've updated the description and the summary before posting this comment.

Philipp, could you please try this patch in this manner (to avoid bug 502438):

- in month/multiweek views drag slowly (in particular when dragging across day boxes if there are others events or shadows in the next day box).

alternatively (to definitely avoid bug 502438):
- drag where there aren't event boxes or shadow boxes (see attached screenshot)

In particular the "all day event header" in week view is very sensible to bug 502438 and you can avoid it (only) if you do as showed in the screenshot.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 428653 [details] [diff] [review]
patch

You are right. With the steps you mentioned, the patch works fine. r=philipp

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4195f728e2a6>

-> FIXED