547083 - configure bails for Python 2.6 (on Ubuntu 9.10?)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Install Ubuntu 9.10, which has Python 2.6
2. Get mozilla-central
3. make -f client.mk

Actual result:
checking for minimum required Python version >= 2.4... /.../src/mozilla/configure: 6403: /usr/bin/python2.5: not found
configure: error: Python 2.4 or higher is required.
configure: error: /.../src/mozilla/configure failed for mozilla

Note that it says >= 2.4, but doesn't find 2.6.

Workaround:
# cd /usr/bin
# ln -s python2.6 python2.5
With that, configure continues.

Expected result:
configure finds Python 2.6 and uses it, given that 2.6 >= 2.4

Comment 1

[(not currently active) Ted Mielczarek]

I think you have a bad version in your config.cache. Try removing that and re-running configure.

configure does look for a "python2.5" binary before looking for "python", but the fact that you have a full path in there makes me suspicious of the cache. (Did you update from an older Ubuntu where 2.5 was your default?)
http://mxr.mozilla.org/mozilla-central/source/configure.in#838

Comment 2

[Ben Bucksch (:BenB)]

> I think you have a bad version in your config.cache.

Nope. config.cache is (correctly so) in the bin/ dir. I blew that away entirely before the configure.

> Did you update from an older Ubuntu?

OK, the history: I had used an older SuSE until yesterday, and now switched to Ubuntu 9.10. I reused the Mozilla source trees. I noticed that the bin/ doesn't want to work under Ubuntu anymore, and remembered the purpose of |configure|, and moved the bin/ dir originating from suse away, cd-ed into source and ran make -f client.mk. Installed missing dev libs a few times. Ran into this bug. Fixed it by the python2.5 symlink, configure passed. Removed the symlink, blew away the bin/ dir, ran configure again, again the configure error. Created the symlink again, reran configure (I think this time with the same bin/ dir), it passed. At this point I filed this bug.

Comment 3

[(not currently active) Ted Mielczarek]

I still think this is something in your system. configure just looks for each of those binaries by name in $PATH. For reference, I'm building on Ubuntu 9.10, and it picks up /usr/bin/python2.5 for me, although /usr/bin/python is 2.6. Works fine.

Comment 4

[Ben Bucksch (:BenB)]

> I still think this is something in your system.

Well,
1. this is a completely freshly installed Ubuntu, no messing, just apt-get build-dep thunderbird and adding the deps that this missed.
2. build dir was entirely removed
3. I don't think anything relevant in .mozconfig
4. the source dir had been used under SuSE, but that, by definition of source dir, must not have any influence, because the source dir must be treated as effectively read-only. If the reason is in the source dir, it's a build bug, too.
To entirely rule 3. and 4. out as well, I'll try an entirely fresh build with minimal .mozconfig.

Comment 5

[Benjamin Smedberg]

In config.log, what do we set for PYTHON?

MOZ_PATH_PROGS(PYTHON, $PYTHON python2.5 python2.4 python)

If we're actually finding /usr/bin/python2.5 even though it doesn't exist, that's not a bug in the version-detection, it's a bug in MOZ_PATH_PROGS.

Comment 6

[Ben Bucksch (:BenB)]

grep -i python mozilla/config.log
configure:3856: checking for python2.5
configure:6405: checking for minimum required Python version >= 2.4

I can no longer reproduce the bug, although I rm /usr/bin/python2.5 and rm -rf /usr/lib/python2.5/ (which I didn't create!), but in the meantime, I ran a system update and installed a python package, and the Ubuntu python installer noticed my python2.5 and configured stuff for python2.5, so configure may be picking up on that.

You'd need to test this on a virgin Ubuntu 9.10.

Comment 7

[Hanspeter Niederstrasser]

I saw this as well on OS X when I upgraded my Fink default python from 2.5 to 2.6 (and removed /sw/bin/python2.5)

make -f client.mk output:
checking for python2.5... (cached) /sw/bin/python2.5
...
checking for minimum required Python version >= 2.4... /src/mozilla-central/configure: line 6409: /sw/bin/python2.5: No such file or directory
configure: error: Python 2.4 or higher is required.
*** Fix above errors and then restart with               "make -f client.mk build"

Removing $OBJDIR/config.cache (which had ac_cv_path_PYTHON=${ac_cv_path_PYTHON=/sw/bin/python2.5}) lets the build continue

make -f client.mk output after removing config.cache:
checking for python2.5... /usr/bin/python2.5
...
checking for minimum required Python version >= 2.4... yes

So it seems like the cached version is being checked for, even if that version no longer exists.

Comment 8

[Justin Wood (:Callek)]

(In reply to comment #7)
> checking for python2.5... (cached) /sw/bin/python2.5

Solution when changing system stuff is to |rm -rf config.cache| or even better yet; just drop your whole ObjectDir on the floor; as when you change your own deps like this, it can happen.

Comment 9

[Ben Bucksch (:BenB)]

> just drop your whole ObjectDir on the floor

As mentioned above, I had done that and still saw the bug.

Comment 10

[Justin Wood (:Callek)]

(In reply to comment #9)
> > just drop your whole ObjectDir on the floor
> 
> As mentioned above, I had done that and still saw the bug.

my c#8 was only in ref to c#7.

For you, a few things I would like you to check for me.

Where does @OBJDIR@ point.
Where in your system do you have config.cache (for anything mozilla-related).
What is the value of $PYTHON.

And ted, do you think it would be worth modifying configure.in to also check/find python2.6 before all other versions?

Comment 11

[(not currently active) Ted Mielczarek]

We could do that, it's a trivial patch.

Comment 12

[Justin Wood (:Callek)]

Attachment: find py2.6 too.

Comment 13

[Justin Wood (:Callek)]

Pushed to m-c as http://hg.mozilla.org/mozilla-central/rev/e57c4a5e35fb

Comment 14

[Justin Wood (:Callek)]

Ben, if this push fixes your issue, lets close this bug out please.

Comment 15

[Ben Bucksch (:BenB)]

I just updated and also took the patch from bug 553867, and I no longer see the bug, *but* I didn't see the bug even before anymore, see comment 6, so I cannot verify whether this patch here fixed the issue.

Comment 16

[Justin Wood (:Callek)]

(In reply to comment #15)
> I just updated and also took the patch from bug 553867, and I no longer see the
> bug, *but* I didn't see the bug even before anymore, see comment 6, so I cannot
> verify whether this patch here fixed the issue.

It does seem like this issue is fixed though