547095 - Try-server email body is missing nickname for WinMo & Maemo builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Daniel Holbert [:dholbert]]

The TryServer auto-emails for WinMo & Maemo are missing a string at the end of the first sentence -- they say e.g.:

> SUBJECT: Try Server: success on WinMo try hg build
> BODY: Your Try Server build (try-6b4ff24cfebb) was successfully completed on .

> SUBJECT: Your Try Server build (try-6b4ff24cfebb) was successfully completed on .
> BODY: Your Try Server build (try-6b4ff24cfebb) failed to complete on .

Should say "on winmo" and "on maemo" there.

Compare to this correct email:
> Try Server: success on WINNT 5.2 try hg build
> Your Try Server build (try-6b4ff24cfebb) was successfully completed on win32.

NOTE: it looks like we have two distinct nicknames for the same platform, and we use one in the subject line and one in the email body. (e.g. "WINNT 5.2" vs "win32" above.  also: "OS X 10.5.2" vs "mac", and "Linux" vs "linux")  I'm guessing we're just missing the latter nickname on WinMo & Maemo.

Comment 1

[Chris Cooper [:coop] (he/him)]

(In reply to comment #0)
> NOTE: it looks like we have two distinct nicknames for the same platform, and
> we use one in the subject line and one in the email body. (e.g. "WINNT 5.2" vs
> "win32" above.  also: "OS X 10.5.2" vs "mac", and "Linux" vs "linux")  I'm
> guessing we're just missing the latter nickname on WinMo & Maemo.

Good call:

http://hg.mozilla.org/build/buildbotcustom/file/996d58ea54a5/status/generators.py#l20

Comment 2

[Rail Aliiev [:rail]]

Attachment: Proposed fix

Coop,

Please review the following patch.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 428882 [details] [diff] [review]
Proposed fix

Looks good. I'll get this landed shortly.

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 428882 [details] [diff] [review]
Proposed fix

http://hg.mozilla.org/build/buildbotcustom/rev/6f1209994e4e

Now we just have to schedule some tryserver downtime to reconfig.

Rail: can you talk to Armen (since he's on buildduty this week) about scheduling the downtime? Thanks.

Comment 5

[Armen [:armenzg]]

I will reconfigure it in the morning 6AM PST.

Try might go down and therefore I shall send an announcement.

Comment 6

[Armen [:armenzg]]

Done. No problems.

Rail all yours to close it or do whatever you need to do.