547228 - Translated strings in templates are truncated

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[David Tenser [:djst]]

https://support.mozilla.com/es/kb/Windows+start+page

The paragraph above the search box is supposed to read:

¿Necesitas ayuda con Firefox? Empieza buscando en nuestro sitio aquí abajo, o navega por la lista de artículos de asistencia más populares. Si no encuentras la respuesta que necesitas, la comunidad de voluntarios está lista para ayudarte a encontrar una solución.

But for some reason, all that's shown is:

¿Necesitas ayuda con Firefox? Empieza buscando en nuestro sitio aquí abajo, o navega por la lista de artículos de asistencia más populares. Si no encuentras la respuesta que necesitas, la comunidad de voluntarios está li

I suspect this is a Tiki bug, so a workaround might be to just change the template so this string is split up into two, e.g.:

{tr}Need help with Firefox? Start by searching our site below, or browse our list of popular support articles.{/tr} {tr}If you can't find the answer you need, our community volunteers are ready to help you find a solution.{/tr}

This bug affects the German page as well: https://support.mozilla.com/de/kb/Windows+start+page

Comment 1

[David Tenser [:djst]]

Laura, this will need a separate push before Tuesday Feb 23. :(

Comment 2

[Laura Thomson :laura]

Paul, we need to fix this and do a push today, Friday 19th, since the ballot website is up today.

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: v1, uses workaround described in comment 0

This uses the workaround David described, splitting the string into two parts. I've made this change only apply to the windows 7 templates to avoid regressions.

Other solutions I've tried were not so easy. Unfortunately, the database structure for tiki_language uses tinyblob, which is limited to 255 characters, so we would need to change a column type over 125,000 rows to fix it in the database.

Another solution I can think of is to use content templates.

Comment 4

[Laura Thomson :laura]

Comment on attachment 427787 [details] [diff] [review]
v1, uses workaround described in comment 0

wfm

Comment 5

[David Tenser [:djst]]

Chris, can you verify that this works on stage and then, after this is pushed, update the affected locales again? Thanks!

Comment 6

[David Tenser [:djst]]

Paul: thanks for the quick patch. I don't see a reason to fix this properly -- splitting up the template strings works. :)

Comment 7

[Laura Thomson :laura]

Paulc: commit this to trunk and the 1.5.1 branch please :)

Comment 8

[Paul Craciunoiu [:paulc]]

r62723/r62724
Over to Chris/QA for verification.

Comment 9

[Chris Ilias [:cilias]]

VERIFIED on <https://support-stage.mozilla.com/es/kb/Windows+start+page>.
Text above search box is:
¿Necesitas ayuda con Firefox? Empieza buscando en nuestro sitio aquí abajo, o navega por la lista de artículos de asistencia más populares. Si no encuentras la respuesta que necesitas, la comunidad de voluntarios está lista para ayudarte a encontrar una solución.

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

Perfect, thanks for your quick work!