547292 - clean up plugin binding styling

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

1) color should be specified next to background-color
2) display:none functional styling should be in content css rather than theme-dependent

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 427819 [details] [diff] [review]
patch

Probably should move the .mainBox width/height/overflow rules to pluginProblemContent.css too, since they're functional.

But r- because the html|A rule needs to stay (but as html|a, like bz noted, though that's a carryover from the old CSS). Without it, the links show up in the default blue/purple colors, which isn't wanted here.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Wow, I failed to notice that when I tested this. I moved some of the other "functional" rules in this patch, too (focus, default size).

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 427996 [details] [diff] [review]
patch

Oh, we can probably just nuke the attempt to default to 240x200... See bug 545514 comment 11. This doesn't event work right when the object's size was CSS controlled. But if you'd rather leave that for a different bug to handle, that's fine too.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fca2aa9b4101

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/49d5fffc6d8f

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> http://hg.mozilla.org/mozilla-central/rev/49d5fffc6d8f

oops, good catch! and thanks for the check-in.

Comment 8

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/a34d24141752
http://hg.mozilla.org/projects/firefox-lorentz/rev/0aa34dd68f2e

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 10

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430