Closed Bug 547292 Opened 13 years ago Closed 13 years ago

clean up plugin binding styling

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(status1.9.2 .4-fixed)

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 file, 1 obsolete file)

1) color should be specified next to background-color
2) display:none functional styling should be in content css rather than theme-dependent
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #427819 - Flags: review?(dolske)
Comment on attachment 427819 [details] [diff] [review]
patch

Probably should move the .mainBox width/height/overflow rules to pluginProblemContent.css too, since they're functional.

But r- because the html|A rule needs to stay (but as html|a, like bz noted, though that's a carryover from the old CSS). Without it, the links show up in the default blue/purple colors, which isn't wanted here.
Attachment #427819 - Flags: review?(dolske) → review-
Attached patch patchSplinter Review
Wow, I failed to notice that when I tested this. I moved some of the other "functional" rules in this patch, too (focus, default size).
Attachment #427819 - Attachment is obsolete: true
Attachment #427996 - Flags: review?(dolske)
Comment on attachment 427996 [details] [diff] [review]
patch

Oh, we can probably just nuke the attempt to default to 240x200... See bug 545514 comment 11. This doesn't event work right when the object's size was CSS controlled. But if you'd rather leave that for a different bug to handle, that's fine too.
Attachment #427996 - Flags: review?(dolske) → review+
http://hg.mozilla.org/mozilla-central/rev/fca2aa9b4101
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
(In reply to comment #6)
> http://hg.mozilla.org/mozilla-central/rev/49d5fffc6d8f

oops, good catch! and thanks for the check-in.
Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.