547336 - Make installation work on Windows with Strawberry Perl Professional

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

So, I just did some testing and I found that only a few changes in the installation process were necessary to make Bugzilla work on Windows with the new Strawberry Perl Professional Alpha.

Technically I'm the Module Owner for Installation, so I could just grant myself review on this, but I want a review mostly to make sure that everything here still works on ActiveState. In particular, does my ON_ACTIVESTATE check work on older versions of ActiveState? I don't have any handy, I thought maybe you might?

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Comment 2

[:glob ✱]

Comment on attachment 427872 [details] [diff] [review]
v1

doesn't work :(

use Win32::BuildNumber

http://kobesearch.cpan.org/htdocs/Win32/Win32.html#Win32_BuildNumber

we should probably change build-id check in install as well.

Comment 3

[Max Kanat-Alexander]

Attachment: v2

Okay, how's this one look?

Comment 4

[Max Kanat-Alexander]

Attachment: v3

Oh, I see what you mean about the build number check. Yeah, fixed that.

Comment 5

[:glob ✱]

Comment on attachment 428124 [details] [diff] [review]
v2

r=glob

Comment 6

[:glob ✱]

Comment on attachment 428125 [details] [diff] [review]
v3

r=glob

Comment 7

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified install-module.pl
modified Bugzilla/Constants.pm
modified Bugzilla/Install/Requirements.pm
Committed revision 7025.

Comment 8

[Max Kanat-Alexander]

Added to the release notes in bug 604256.