Mac packaged builds are completely broken by not packaging libwidget_mac.dylib

VERIFIED FIXED in seamonkey2.1a1

Status

SeaMonkey
Build Config
--
major
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
seamonkey2.1a1
All
Mac OS X
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 428000 [details] [diff] [review]
Fix

Because widget: cocoa is filled with hate and nastiness, and it wants to make your life as miserable as it possibly can, it has LIBRARY_NAME = widget_mac and XPIDL_MODULE = widget_cocoa, so you need to package libwidget_mac.dylib and widget_cocoa.xpt, rather than the libwidget_cocoa.dylib and no extra xpt that you are currently packaging.
Flags: in-testsuite-
Attachment #428000 - Flags: review?(kairo)
Blocks: 521523
Comment on attachment 428000 [details] [diff] [review]
Fix

>@@ -427,16 +427,19 @@ bin/components/@DLL_PREFIX@nkgnomevfs@DL
>+#ifdef XP_MAC_OSX

XP_MACOSX...
Ftr, Firefox:
bug 463605
http://hg.mozilla.org/mozilla-central/rev/0bd17bd1cbaf
{
+++ b/browser/installer/osx/packages-static
+@BINPATH@/components/widget.xpt
}

I wonder why c-c apps need to do more? (because not libxul (yet)?)
(Assignee)

Comment 3

7 years ago
Created attachment 428028 [details] [diff] [review]
No, really fix

Be less embarrassing if I hadn't still had the package-compare that was telling me I typoed that ifdef open.

comm-central doesn't have to do more because it's not libxul; it has to do more because it actually has make package-compare, so it knows what it isn't shipping. I'll poke at josh and try to make him admit whether the way Fx has been missing it for as long as it's had a manifest for Mac means it's useless, or means that Fx has been broken.
Attachment #428000 - Attachment is obsolete: true
Attachment #428028 - Flags: review?(kairo)
Attachment #428000 - Flags: review?(kairo)
(Assignee)

Updated

7 years ago
(In reply to comment #3)
> I'll poke at josh and try to make him admit whether the way Fx has
> been missing it for as long as it's had a manifest for Mac means it's useless,
> or means that Fx has been broken.

Thanks: that was the other (implicit) part of my wondering ;->

NB: Would you know why FF doesn't use 'make package-compare'? It looks like a pity (which I've run into a few times).

Comment 5

7 years ago
Comment on attachment 428028 [details] [diff] [review]
No, really fix

Thanks a lot for looking into that!
Attachment #428028 - Flags: review?(kairo) → review+
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/comm-central/rev/b6e895490411
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
V.Fixed, per our packaged tests tinderboxes :-)
Severity: normal → major
Status: RESOLVED → VERIFIED
Blocks: 545628
You need to log in before you can comment on or make changes to this bug.