Created attachment 428000 [details] [diff] [review]
Because widget: cocoa is filled with hate and nastiness, and it wants to make your life as miserable as it possibly can, it has LIBRARY_NAME = widget_mac and XPIDL_MODULE = widget_cocoa, so you need to package libwidget_mac.dylib and widget_cocoa.xpt, rather than the libwidget_cocoa.dylib and no extra xpt that you are currently packaging.
Comment on attachment 428000 [details] [diff] [review]
>@@ -427,16 +427,19 @@ bin/components/@DLL_PREFIX@nkgnomevfs@DL
I wonder why c-c apps need to do more? (because not libxul (yet)?)
Created attachment 428028 [details] [diff] [review]
No, really fix
Be less embarrassing if I hadn't still had the package-compare that was telling me I typoed that ifdef open.
comm-central doesn't have to do more because it's not libxul; it has to do more because it actually has make package-compare, so it knows what it isn't shipping. I'll poke at josh and try to make him admit whether the way Fx has been missing it for as long as it's had a manifest for Mac means it's useless, or means that Fx has been broken.
(In reply to comment #3)
> I'll poke at josh and try to make him admit whether the way Fx has
> been missing it for as long as it's had a manifest for Mac means it's useless,
> or means that Fx has been broken.
Thanks: that was the other (implicit) part of my wondering ;->
NB: Would you know why FF doesn't use 'make package-compare'? It looks like a pity (which I've run into a few times).
Comment on attachment 428028 [details] [diff] [review]
No, really fix
Thanks a lot for looking into that!
V.Fixed, per our packaged tests tinderboxes :-)