547627 - formattm test fails on windows mobile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

There are a couple of problems with the strftime in the shunt that PR_FormatTime relies on.

1) the version of wcsftime that takes a narrow pattern seems to be broken, just returns garbage.
2) if wcsftime fails, we try to convert that wide char garbage to narrow chars
2a) the return value of WideCharToMultiByte is meaningless if wcsftime fails (garbage in, garbage out).

Comment 1

[Wan-Teh Chang]

Brad,

Since your patch modifies only build/wince/shunt/time.cpp
and not any NSPR file, perhaps you should change the Product
of this bug report to the wince shunt library.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 428119 [details] [diff] [review]
patch

test for null tmpBuf.
test for a zero wpatlen.
test for null wpat.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 428319 [details] [diff] [review]
patch v.2

>+  if (!tmpBuf) {
>+    free(wpat);
>+    return 0;
>+  }
>+  MultiByteToWideChar(CP_ACP, 0, pat, -1, wpat, wpatlen);
>   if (!tmpBuf)
>     return 0;

I do not understand the second test here.  Shouldn't you test for the result of MultiByteToWideChar, or the length of wpatlen, or both?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.3

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 428321 [details] [diff] [review]
patch v.3

not a big fan of deep nesting, but..

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/58c60f220da2

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 428321 [details] [diff] [review]
patch v.3

Hey Brad, trying to understand what this blocks in terms of your Fennec progress.

I don't think we're going to take this unless it's a Fennec blocker.