gfxSharedImageSurface.cpp failed to compile on Solaris

RESOLVED FIXED in mozilla1.9.3a3

Status

()

Core
Widget
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Trunk
mozilla1.9.3a3
x86
OpenSolaris
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

557 bytes, patch
jrmuizel
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
"../../../../gfx/thebes/src/gfxSharedImageSurface.cpp", line 64: Error: Formal argument 1 of type char* in call to shmdt(char*) is being passed unsigned char*.

man shmdt on Solaris

SYNOPSIS
     #include <sys/types.h>
     #include <sys/shm.h>

     void *shmat(int shmid, const void *shmaddr, int shmflg);

     int shmdt(char *shmaddr);

  Standard conforming
     int shmdt(const void *shmaddr);

I think we can cast to "char *", it should also work for the shmdt(void *) declaration.
(Assignee)

Comment 1

8 years ago
Created attachment 428154 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #428154 - Flags: review?(jmuizelaar)
Attachment #428154 - Attachment is patch: true
Attachment #428154 - Attachment mime type: application/octet-stream → text/plain
Version: unspecified → Trunk
I wonder if it would be better to just not build this file on Solaris. It shouldn't be needed there.
(Assignee)

Comment 3

8 years ago
It is only needed for QT toolkit, right?

so
ifeq ($(MOZ_WIDGET_TOOLKIT),qt)
CPPSRCS += \
        gfxSharedImageSurface.cpp \
        $(NULL)
endif

Is it correct?
(Assignee)

Comment 4

8 years ago
Created attachment 429092 [details] [diff] [review]
patch v2

From
http://mxr.mozilla.org/mozilla-central/search?string=gfxSharedImageSurface

It is only used by qt.
Attachment #429092 - Flags: review?(jmuizelaar)
Attachment #429092 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 5

8 years ago
Comment on attachment 428154 [details] [diff] [review]
patch

Not needed, unless use qt toolkit on Solaris.
Attachment #428154 - Flags: review?(jmuizelaar)
(Assignee)

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b4f8880a80c2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Attachment #428154 - Attachment is obsolete: true
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.