547657 - gfxSharedImageSurface.cpp failed to compile on Solaris

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Ginn Chen]

"../../../../gfx/thebes/src/gfxSharedImageSurface.cpp", line 64: Error: Formal argument 1 of type char* in call to shmdt(char*) is being passed unsigned char*.

man shmdt on Solaris

SYNOPSIS
     #include <sys/types.h>
     #include <sys/shm.h>

     void *shmat(int shmid, const void *shmaddr, int shmflg);

     int shmdt(char *shmaddr);

  Standard conforming
     int shmdt(const void *shmaddr);

I think we can cast to "char *", it should also work for the shmdt(void *) declaration.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I wonder if it would be better to just not build this file on Solaris. It shouldn't be needed there.

Comment 3

[Ginn Chen]

It is only needed for QT toolkit, right?

so
ifeq ($(MOZ_WIDGET_TOOLKIT),qt)
CPPSRCS += \
        gfxSharedImageSurface.cpp \
        $(NULL)
endif

Is it correct?

Comment 4

[Ginn Chen]

Attachment: patch v2

From
http://mxr.mozilla.org/mozilla-central/search?string=gfxSharedImageSurface

It is only used by qt.

Comment 5

[Ginn Chen]

Comment on attachment 428154 [details] [diff] [review]
patch

Not needed, unless use qt toolkit on Solaris.

Comment 6

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/b4f8880a80c2