"../../../../gfx/thebes/src/gfxSharedImageSurface.cpp", line 64: Error: Formal argument 1 of type char* in call to shmdt(char*) is being passed unsigned char*. man shmdt on Solaris SYNOPSIS #include <sys/types.h> #include <sys/shm.h> void *shmat(int shmid, const void *shmaddr, int shmflg); int shmdt(char *shmaddr); Standard conforming int shmdt(const void *shmaddr); I think we can cast to "char *", it should also work for the shmdt(void *) declaration.
Created attachment 428154 [details] [diff] [review] patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
I wonder if it would be better to just not build this file on Solaris. It shouldn't be needed there.
It is only needed for QT toolkit, right? so ifeq ($(MOZ_WIDGET_TOOLKIT),qt) CPPSRCS += \ gfxSharedImageSurface.cpp \ $(NULL) endif Is it correct?
Created attachment 429092 [details] [diff] [review] patch v2 From http://mxr.mozilla.org/mozilla-central/search?string=gfxSharedImageSurface It is only used by qt.
Attachment #429092 - Flags: review?(jmuizelaar)
Attachment #429092 - Flags: review?(jmuizelaar) → review+
Comment on attachment 428154 [details] [diff] [review] patch Not needed, unless use qt toolkit on Solaris.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Attachment #428154 - Attachment is obsolete: true
Target Milestone: --- → mozilla1.9.3a3
You need to log in before you can comment on or make changes to this bug.