Port Bug 523771 [Support <input type=file multiple>] sessionstore part to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]

From parent bug:

"If the 'multiple' attribute is set on an <input type=file> then we should use a
filepicker that allows multiple files to be selected.

All the files should then be used when submitting, and be available through the
HTMLInputElement.files properly."

This is only sessionstore part, tests for this bug will be in coming sessionstore tests patch.
Attachment #428192 - Flags: superreview?(neil)
Attachment #428192 - Flags: review?(neil)
Attachment #428192 - Attachment is patch: true
Attachment #428192 - Attachment mime type: application/octet-stream → text/plain

Comment 1

8 years ago
Comment on attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]

I wonder why nobody complained about backward compatibility, but I guess that keeping file input data across versions is a low priority ;-)
Attachment #428192 - Flags: superreview?(neil)
Attachment #428192 - Flags: superreview+
Attachment #428192 - Flags: review?(neil)
Attachment #428192 - Flags: review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

8 years ago
Neil, I just found this -  Bug 524533. Is it worth new bug or I can post modified patch for checkin here ?
Comment on attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/70684cdfcd65
Attachment #428192 - Attachment description: patch → patch [Checkin: Comment 3]
(In reply to comment #2)
> Bug 524533. Is it worth new bug ... ?

Here is fine.
Depends on: 524533
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Comment 5

8 years ago
Created attachment 428427 [details] [diff] [review]
mozGetFileNameArray length out param should be optional
[Checkin: Comment 6]

One line patch.
Attachment #428427 - Flags: superreview?(neil)
Attachment #428427 - Flags: review?(neil)

Updated

8 years ago
Attachment #428427 - Flags: superreview?(neil)
Attachment #428427 - Flags: superreview+
Attachment #428427 - Flags: review?(neil)
Attachment #428427 - Flags: review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Comment on attachment 428427 [details] [diff] [review]
mozGetFileNameArray length out param should be optional
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/28d0237c1df8
Attachment #428427 - Attachment description: mozGetFileNameArray length out param should be optional → mozGetFileNameArray length out param should be optional [Checkin: Comment 6]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.