Last Comment Bug 547710 - Port Bug 523771 [Support <input type=file multiple>] sessionstore part to SeaMonkey
: Port Bug 523771 [Support <input type=file multiple>] sessionstore part to Se...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Misak Khachatryan
:
Mentors:
Depends on: 523771 524533
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-22 05:47 PST by Misak Khachatryan
Modified: 2010-02-24 00:18 PST (History)
0 users
bugzillamozillaorg_serge_20140323: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch [Checkin: Comment 3] (1.24 KB, patch)
2010-02-22 05:47 PST, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Review
mozGetFileNameArray length out param should be optional [Checkin: Comment 6] (650 bytes, patch)
2010-02-23 04:21 PST, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Review

Description Misak Khachatryan 2010-02-22 05:47:32 PST
Created attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]

From parent bug:

"If the 'multiple' attribute is set on an <input type=file> then we should use a
filepicker that allows multiple files to be selected.

All the files should then be used when submitting, and be available through the
HTMLInputElement.files properly."

This is only sessionstore part, tests for this bug will be in coming sessionstore tests patch.
Comment 1 neil@parkwaycc.co.uk 2010-02-22 06:51:33 PST
Comment on attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]

I wonder why nobody complained about backward compatibility, but I guess that keeping file input data across versions is a low priority ;-)
Comment 2 Misak Khachatryan 2010-02-22 23:01:01 PST
Neil, I just found this -  Bug 524533. Is it worth new bug or I can post modified patch for checkin here ?
Comment 3 Serge Gautherie (:sgautherie) 2010-02-23 03:21:21 PST
Comment on attachment 428192 [details] [diff] [review]
patch
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/70684cdfcd65
Comment 4 Serge Gautherie (:sgautherie) 2010-02-23 03:25:24 PST
(In reply to comment #2)
> Bug 524533. Is it worth new bug ... ?

Here is fine.
Comment 5 Misak Khachatryan 2010-02-23 04:21:05 PST
Created attachment 428427 [details] [diff] [review]
mozGetFileNameArray length out param should be optional
[Checkin: Comment 6]

One line patch.
Comment 6 Serge Gautherie (:sgautherie) 2010-02-24 00:18:27 PST
Comment on attachment 428427 [details] [diff] [review]
mozGetFileNameArray length out param should be optional
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/28d0237c1df8

Note You need to log in before you can comment on or make changes to this bug.