547731 - browser-ui.js#159 tab is null error

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The icon can came from a subdocument and actually getTabForDocument return a tab only if the top document match the icon's document.

The patch prevent the error by checking if tab if the icon came from the top document and not by checking if tab is null because I guess there are patches somewhere that are going to alter getTabForDocument to handle subdocument.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we have example websites where this happens? I'd like to see more background.

Comment 2

[Oleg Romashin (:romaxa)]

not sure, but I think I've seen this problem too... on debug/logging build...

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Do we have example websites where this happens? I'd like to see more
> background.

Sorry to forgot the steps to repro here! Just go to : http://www.vancouver2010.com/fr/ski-alpine-olympique/ and look at the error console

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Also this web site: http://mns.com (notice that's not msn)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/320053559634