Closed Bug 547731 Opened 10 years ago Closed 10 years ago

browser-ui.js#159 tab is null error

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The icon can came from a subdocument and actually getTabForDocument return a tab only if the top document match the icon's document.

The patch prevent the error by checking if tab if the icon came from the top document and not by checking if tab is null because I guess there are patches somewhere that are going to alter getTabForDocument to handle subdocument.
Attachment #428228 - Flags: review?(mark.finkle)
Do we have example websites where this happens? I'd like to see more background.
not sure, but I think I've seen this problem too... on debug/logging build...
(In reply to comment #1)
> Do we have example websites where this happens? I'd like to see more
> background.

Sorry to forgot the steps to repro here! Just go to : http://www.vancouver2010.com/fr/ski-alpine-olympique/ and look at the error console
Also this web site: http://mns.com (notice that's not msn)
Attachment #428228 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/320053559634
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.