547748 - Wrong parsing of email_in emails if some @field has no data

Status: RESOLVED FIXED

(Bugzilla :: Incoming Email, defect)

Description

[Frédéric Buclin]

If you leave @groups empty (to skip default groups) as below...

@product Test1
@component comp1
@version 1.3
@groups

...  email_in.pl complains that:
"There is no version named '1.3 @groups' in the 'Test1' product."

If I type |@groups =| (I added "="), then the parsing is fine. As "=" is optional since bug 526158, we should parse such cases correctly.

Comment 1

[Frédéric Buclin]

The problem comes from line 110:

if ($line =~ /^\@(\S+)\s*(?:=|\s)\s*(.*)\s*/)

If you simply pass @foo, it's appended to the previous field, because it doesn't match the regexp.

Comment 2

[Max Kanat-Alexander]

Ahh, probably putting a * after the = stuff and a +? on the \S would fix it.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Also catch ^\@\S+\s*$

Comment 4

[Max Kanat-Alexander]

Comment on attachment 461921 [details] [diff] [review]
patch, v1

Ah yeah, that's a simple, clever solution. :-)

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified email_in.pl
Committed revision 7410.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified email_in.pl
Committed revision 7354.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified email_in.pl
Committed revision 7149.