547786 - gloda deleted folder tombstones prevent indexing of re-created folders in same session

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

If you delete a folder, gloda:
- Blow away the database entry for the GlodaFolder
- Marks the GlodaFolder instance as _deleted
- Leaves the GlodaFolder present in all in-memory maps.

This is too effective a tombstone because if a new folder is created with the same name, the tombstone is returned for that new folder.

The user workaround is to restart Thunderbird; when Thunderbird next starts the (in-memory-only) tombstone is gone and the folder will be treated normally.

The solution is likely to remove the tombstone from in-memory maps.  The tombstone will still be accessible for anyone hanging onto the reference, but will not preclude creation of a new folder instance.

The programmatic workaround is then:
  delete GlodaDatastore._folderByURI[deadFolder.URI];

Comment 1

[Shane Caraveo (:mixedpuppy)]

I'm not certain our original analysis of the problem is correct.  After our discussion, I still could not get proper indexing on a new folder so I tried from scratch.  I've created a new profile and an account using imap.  I installed glodaquilla so I could see some status on the indexing.  

Starting up with the new profile, gloda indexes my inbox (only a couple dozen messages on this account).  I manually create a new folder "test", and manually drag/drop a message from inbox into that folder.  That new message never gets indexed until a restart.  I haven't deleted any imap folders in this profile.

I added a couple more lines of debug logging to gloda/index_msg.js, in _reindexChangedMessages.  The folder is flagged with glodaFolder.kFolderFilthy.  I don't seem to get an indexing sweep into the new folder.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

(This later problem turned out to be bug 547877.  Hooray for Shane finding the only 2 remaining bugs in gloda!)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Fix is up on bug 547877; I'll mark this fixed when that gets marked fixed.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(This was fixed with the fix for bug 547877.)