547827 - JavaScript strict warning: modules/util.js, line 617: reference to undefined property thisObj[name]

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Not sure how much we really care about these warnings, but I don't see any harm in fixing them...

In the case when thisObj[name] doesn't exist, we get a JS strict warning. So we can just check if the property exists first before seeing if it's an instance of nsITimer.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Added: name in thisObj &&

Comment 2

[Ed Lee :Mardak]

Comment on attachment 428286 [details] [diff] [review]
Patch v0.1

Curious, do you see other undefined property warnings? I think deferGetSet triggers them, but some callers also expect |undefined|.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #2)
> Curious, do you see other undefined property warnings? I think deferGetSet
> triggers them, but some callers also expect |undefined|.

Yea, there's one in ClientStore.getInfo (related to wiping) which I'm looking at now.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed http://hg.mozilla.org/labs/weave/rev/b53a4e63db18
Check that name is a property of thisObj before trying to access it.