547828 - 'mostpopular-new' DIV is causing text in 'morearticles' class to be in italics

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Articles, task)

Description

[Chris Ilias [:cilias]]

When adding the 'morearticles' text to <https://support.mozilla.com/en-US/kb/Windows+start+page>, I noticed that the text appeared in bold, not italics. On the regular start page <https://support.mozilla.com/en-US/kb/>, that text appears in italics, not bold.

I did some testing and found that the italics are caused by the 'mostpopular-new' DIV.

I think it looks fine either way, but if I had to choose, I prefer that text to be in italics.

Having said that, that text should not be affected by a DIV for another block of text (which doesn't use italics anyway).
Should we change the markup from:
{DIV(id=>mainpagecontainer)}
{DIV(id=>mostpopular-new)}
!!Popular Support Articles
{content id=9}
{DIV(class=>morearticles)}
There are over 200 support articles for Firefox. ((Article list|Browse them all »))
{DIV}
{DIV}
{DIV}

to

{DIV(id=>mainpagecontainer)}
{DIV(id=>mostpopular-new)}
!!Popular Support Articles
{content id=9}
{DIV}
{DIV(class=>morearticles)}
There are over 200 support articles for Firefox. ((Article list|Browse them all »))
{DIV}
{DIV}

It feels like we need to remove the italics from the 'mostpopular-new' DIV and apply it to the 'morearticles' class.

Comment 1

[James Socol [:jsocol, :james]]

Yes, if the <div>s are nesting improperly, your solution will fix that.

If there are CSS changes that need to happen after you change this, bounce it back to the KB Software component.

Comment 2

[[:Cww]]

If you fix the nesting then the styles get messed up.  I'm OK with leaving this as is (even though the styles and nesting is weird) for now and fix it in the new template.

Comment 3

[Chris Ilias [:cilias]]

We discussed this in this week's meeting, and decided that if the css is wrong, it's not worth spending sumodev resources on.

I removed the DIV from morearticles div from the Windows start page, and applied the italics/bold manually.