No OOM check on trace when creating a null closure in JSOP_LAMBDA

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Waldo, Unassigned)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Comment 1

6 years ago
I'm assuming this entails adding a guard statement with an OOM_EXIT.  Is a similar OOM check missing from http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#15742 ?
Created attachment 552004 [details] [diff] [review]
Guard for OOM when creating null closures for JSOP_LAMBDA.

No significant performance difference.  All existing tests pass, but no new tests are included.  There are OOM tests for Function() in jit-test/tests/basic/testCompileScript.js, but it's not clear to me how I can apply that technique to testing creation of null closure lambdas.  Any hints would be appreciated.
Attachment #552004 - Flags: review?(jwalden+bmo)
Attachment #552004 - Flags: review?(dmandelin)
Comment on attachment 552004 [details] [diff] [review]
Guard for OOM when creating null closures for JSOP_LAMBDA.

Review of attachment 552004 [details] [diff] [review]:
-----------------------------------------------------------------

Only needs one reviewer. Looks fine. I don't mind not having a test case on this particular patch--test cases for OOMs are kind of nasty because they run for a long time and often work differently on different platforms.
Attachment #552004 - Flags: review?(jwalden+bmo)
Attachment #552004 - Flags: review?(dmandelin)
Attachment #552004 - Flags: review+
Attachment #552004 - Flags: checkin?
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [good first bug] → [inbound]
http://hg.mozilla.org/mozilla-central/rev/5691363f380f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

6 years ago
Attachment #552004 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.