547875 - No OOM check on trace when creating a null closure in JSOP_LAMBDA

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Josh Matthews [:jdm]]

I'm assuming this entails adding a guard statement with an OOM_EXIT.  Is a similar OOM check missing from http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#15742 ?

Comment 2

[Terrence Cole [:terrence]]

Attachment: Guard for OOM when creating null closures for JSOP_LAMBDA.

No significant performance difference.  All existing tests pass, but no new tests are included.  There are OOM tests for Function() in jit-test/tests/basic/testCompileScript.js, but it's not clear to me how I can apply that technique to testing creation of null closure lambdas.  Any hints would be appreciated.

Comment 3

[David Mandelin [:dmandelin]]

Comment on attachment 552004 [details] [diff] [review]
Guard for OOM when creating null closures for JSOP_LAMBDA.

Review of attachment 552004 [details] [diff] [review]:
-----------------------------------------------------------------

Only needs one reviewer. Looks fine. I don't mind not having a test case on this particular patch--test cases for OOMs are kind of nasty because they run for a long time and often work differently on different platforms.

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/5691363f380f