Closed Bug 547875 Opened 15 years ago Closed 13 years ago

No OOM check on trace when creating a null closure in JSOP_LAMBDA

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: Waldo, Unassigned)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

No description provided.
I'm assuming this entails adding a guard statement with an OOM_EXIT. Is a similar OOM check missing from http://mxr.mozilla.org/mozilla-central/source/js/src/jstracer.cpp#15742 ?
No significant performance difference. All existing tests pass, but no new tests are included. There are OOM tests for Function() in jit-test/tests/basic/testCompileScript.js, but it's not clear to me how I can apply that technique to testing creation of null closure lambdas. Any hints would be appreciated.
Attachment #552004 - Flags: review?(jwalden+bmo)
Attachment #552004 - Flags: review?(dmandelin)
Comment on attachment 552004 [details] [diff] [review] Guard for OOM when creating null closures for JSOP_LAMBDA. Review of attachment 552004 [details] [diff] [review]: ----------------------------------------------------------------- Only needs one reviewer. Looks fine. I don't mind not having a test case on this particular patch--test cases for OOMs are kind of nasty because they run for a long time and often work differently on different platforms.
Attachment #552004 - Flags: review?(jwalden+bmo)
Attachment #552004 - Flags: review?(dmandelin)
Attachment #552004 - Flags: review+
Attachment #552004 - Flags: checkin?
Keywords: checkin-needed
Whiteboard: [good first bug] → [inbound]
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Attachment #552004 - Flags: checkin? → checkin+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: