547881 - need to serialize/deserialize gfxMatrix

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Joe Drew (not getting mail)]

Attachment: serialize gfxMatrix

This patch allows us to serialize instances of gfxMatrix.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 428326 [details] [diff] [review]
serialize gfxMatrix

>diff --git a/ipc/glue/IPCMessageUtils.h b/ipc/glue/IPCMessageUtils.h
>--- a/ipc/glue/IPCMessageUtils.h
>+++ b/ipc/glue/IPCMessageUtils.h
>+template<>
>+struct ParamTraits<gfxMatrix>
>+{
>+  static bool Read(const Message* aMsg, void** aIter, paramType* aResult)
>+  {
>+    if (!ReadParam(aMsg, aIter, &aResult->xx))
>+      return false;
>+    if (!ReadParam(aMsg, aIter, &aResult->xy))
>+      return false;
>+    if (!ReadParam(aMsg, aIter, &aResult->yx))
>+      return false;
>+    if (!ReadParam(aMsg, aIter, &aResult->yy))
>+      return false;
>+    if (!ReadParam(aMsg, aIter, &aResult->x0))
>+      return false;
>+    if (!ReadParam(aMsg, aIter, &aResult->y0))
>+      return false;
>+
>+    return true;
>+  }
>+

Nit: I prefer

  return ReadParam(aMsg, aIter, &aResult->xx) &&
         ReadParam(aMsg, aIter, &aResult->xy) &&
...

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/15cb4be209b3

w/ nits fixed.

Comment 3

[Markus Stange [:mstange]]

I think you made a mistake when fixing the nit, it now says:

if (...)
  return true;
return true;

Comment 4

[Doug Turner (:dougt)]

Thanks for catching that mistake.  De Morgan is crying for me!



http://hg.mozilla.org/mozilla-central/rev/7bf0383f6f62

Comment 5

[Joe Drew (not getting mail)]

Not or me.