C++ style comments in C unit bsdiff/bsdiff.c/.h

RESOLVED WONTFIX

Status

()

Toolkit
Application Update
RESOLVED WONTFIX
8 years ago
8 years ago

People

(Reporter: ul, Assigned: ul)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 428431 [details] [diff] [review]
replacing C++ comments with C-style 

xlc_r -o host_bsdiff.o -c -DXP_UNIX -O2 -qarch=604 -qmaxmem=-1 -qalias=noansi  -I/home/ulink/src/comm-1.9.1/mozilla/toolkit/mozapps/update/src/updater -I/home/ulink/src/comm-1.9.1/mozilla/other-licenses/bsdiff -I.  -I../../dist/include   -I../../dist/include -I/home/ulink/src/comm-1.9.1/obj-sm2-aix43/mozilla/dist/include/nspr    -I/home/ulink/src/comm-1.9.1/obj-sm2-aix43/mozilla/dist/sdk/include -I/home/ulink/src/comm-1.9.1/obj-sm2-aix43/mozilla/dist/include/nspr /home/ulink/src/comm-1.9.1/mozilla/other-licenses/bsdiff/bsdiff.c
"/home/ulink/src/comm-1.9.1/mozilla/toolkit/mozapps/update/src/updater/bspatch.h", line 35.1: 1506-046 (S) Syntax error.
"/home/ulink/src/comm-1.9.1/mozilla/toolkit/mozapps/update/src/updater/bspatch.h", line 35.4: 1506-166 (S) Definition of function We requires parentheses.
"/home/ulink/src/comm-1.9.1/mozilla/toolkit/mozapps/update/src/updater/bspatch.h", line 35.54: 1506-209 (S) Character constants must end before the end of a line.
"/home/ulink/src/comm-1.9.1/mozilla/toolkit/mozapps/update/src/updater/bspatch.h", line 35.37: 1506-076 (W) Character constant 't link with NSPR' has more than one character. No more than rightmost 4 characters are used.
...

Simply replacing the C++ style comments with C style comments.
(Assignee)

Updated

8 years ago
Attachment #428431 - Attachment is patch: true
Attachment #428431 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 1

8 years ago
Created attachment 428432 [details] [diff] [review]
replacing C++ comments with C-style
Assignee: nobody → ul.mcamafia
Attachment #428431 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Attachment #428432 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

8 years ago
applies to mozilla-central, mozilla-1.9.2 and mozilla-1.9.1
(Assignee)

Updated

8 years ago
Blocks: 535369
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
Comment on attachment 428432 [details] [diff] [review]
replacing C++ comments with C-style 

I would be worried about ever taking a bsdiff update, but I'm pretty sure we've already thoroughly forked this stuff.
Attachment #428432 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
The patch changes toolkit/mozapps/update/src/updater/bspatch.h, but my tree only has toolkit/mozapps/update/updater/bspatch.h... what does this mean?
Since the patch claims to be against 90fbd13348e0, which is a 1.9.1 rev, I'd say it means Uli patched against 1.9.1, instead of against mozilla-central after bug 542222 got rid of the /src/, and the "applies to mozilla-central" meant "... if you haven't updated your m-c tree for several weeks now."
Keywords: checkin-needed
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> Since the patch claims to be against 90fbd13348e0, which is a 1.9.1 rev, I'd
> say it means Uli patched against 1.9.1, instead of against mozilla-central

That's what I did. And visual checking the source for trunk in MXR.
Seems I've missed the moved src dir.

> after bug 542222 got rid of the /src/, and the "applies to mozilla-central"
> meant "... if you haven't updated your m-c tree for several weeks now."

Porting work for trunk stops compilation long,long before coming to this dir.
(Assignee)

Comment 7

8 years ago
Created attachment 432510 [details] [diff] [review]
recreated remaining patch for trunk

Here the part of the patch for trunk that wasn't fixed by
http://hg.mozilla.org/mozilla-central/rev/9b7c5d7fcbda

bspatch.h is included in bsdiff.c
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.