54799 - could not make correctly on NetBSD

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect, P3)

Description

[Shin'ichiro TAYA]

To compile correctly on NetBSD, some modification needed for GETHOSTNAME() and
CTIME() in include/portable.h
GETHOSTNAME() shouled be gethostname and CTIME() should be ctime_r( c, b )

Comment 1

[Shin'ichiro TAYA]

Attachment: patch to solve this problem

Comment 2

[Shin'ichiro TAYA]

Attachment: patch to solve this problem

Comment 3

[Mark Smith [:mcs]]

The patch looks okay.  Reassigning to Michael Hein to apply the patch.

Comment 4

[Shin'ichiro TAYA]

One month passed since last comment. What is the status of this patch?

Comment 5

[David Krause]

Setting correct OS field.
Is someone looking at this patch?

Comment 6

[Mark Smith [:mcs]]

Michael, can you apply this patch to the mozilla tree?    It looks okay to me.

Comment 7

[Michael Hein]

Checkin to 4.0 version:

sorbet > cvs diff -c portable.h
Index: portable.h
===================================================================
RCS file: /cvsroot/mozilla/directory/c-sdk/ldap/include/portable.h,v
retrieving revision 1.2.2.3
diff -c -r1.2.2.3 portable.h
*** portable.h  2000/04/20 16:18:00     1.2.2.3
--- portable.h  2000/11/21 22:51:34
***************
*** 243,249 ****
      defined(UNIXWARE) || defined(SUNOS4) || defined(SNI) || defined(BSDI) || \
      defined(NCR) || defined(OSF1) || defined(NEC) || \
      ( defined(HPUX10) && !defined(_REENTRANT)) || defined(HPUX11) || \
!     defined(UnixWare) || defined(LINUX) || (defined(AIX) && 
!defined(USE_REENTRANT_LIBC))
  #define GETHOSTBYNAME( n, r, b, l, e )  gethostbyname( n )
  #elif defined(AIX)
  /* Maybe this is for another version of AIX?
--- 243,250 ----
      defined(UNIXWARE) || defined(SUNOS4) || defined(SNI) || defined(BSDI) || \
      defined(NCR) || defined(OSF1) || defined(NEC) || \
      ( defined(HPUX10) && !defined(_REENTRANT)) || defined(HPUX11) || \
!     defined(UnixWare) || defined(LINUX) || defined(NETBSD) || \
!     (defined(AIX) && !defined(USE_REENTRANT_LIBC))
  #define GETHOSTBYNAME( n, r, b, l, e )  gethostbyname( n )
  #elif defined(AIX)
  /* Maybe this is for another version of AIX?
***************
*** 273,279 ****
  #elif defined(HPUX10) && defined(_REENTRANT) && !defined(HPUX11)
  #define CTIME( c, b, l )              nsldapi_compat_ctime_r( c, b, l )
  #elif defined( IRIX6_2 ) || defined( IRIX6_3 ) || defined(UNIXWARE) \
!       || defined(OSF1V4) || defined(AIX) || defined(UnixWare) || defined(hpux) 
|| defined(HPUX11)
  #define CTIME( c, b, l )                ctime_r( c, b )
  #elif defined( OSF1V3 )
  #define CTIME( c, b, l )              (ctime_r( c, b, l ) ? NULL : b)
--- 274,280 ----
  #elif defined(HPUX10) && defined(_REENTRANT) && !defined(HPUX11)
  #define CTIME( c, b, l )              nsldapi_compat_ctime_r( c, b, l )
  #elif defined( IRIX6_2 ) || defined( IRIX6_3 ) || defined(UNIXWARE) \
!       || defined(OSF1V4) || defined(AIX) || defined(UnixWare) || defined(hpux) 
|| defined(HPUX11) || defined(NETBSD)
  #define CTIME( c, b, l )                ctime_r( c, b )
  #elif defined( OSF1V3 )
  #define CTIME( c, b, l )              (ctime_r( c, b, l ) ? NULL : b)

Checking in portable.h;
/cvsroot/mozilla/directory/c-sdk/ldap/include/portable.h,v  <--  portable.h
new revision: 1.2.2.4; previous revision: 1.2.2.3
done

Comment 8

[Martin Husemann]

*** Bug 61755 has been marked as a duplicate of this bug. ***

Comment 9

[Martin Husemann]

*** Bug 61755 has been marked as a duplicate of this bug. ***

Comment 10

[Shin'ichiro TAYA]

psm(PSM_1_4_N6) worked.
verified.
Thanks!