548118 - Maemo & WinMo tryserver builds perma-red with "make package failed" and "cd: build/./try/objdir/mobile: No such file or directory"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Daniel Holbert [:dholbert]]

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1266954341.1266956873.15181.gz
Maemo try hg build on 2010/02/23 11:45:41
s: try-linux-slave06

Snippet of failure log:
> ======== BuildStep started ========
> make package failed
> === Output ===
> /scratchbox/moz_scratchbox -p -d build/./try/objdir/mobile make package 
>  in dir /builds/slave/sendchange-maemo-hg/build (timeout 1200 secs)
>  watching logfiles {}
>  argv: ['/scratchbox/moz_scratchbox', '-p', '-d', 'build/./try/objdir/mobile', 'make package', '']
>  environment:
[SNIP]
>  using PTY: True
> eval eval /builds/scratchbox/sbin/chroot-uid /builds/scratchbox/users/cltbld /scratchbox/tools/bin/env - $SBENV /scratchbox/tools/bin/bash -l /scratchbox/tools/bin/exec.sh build/./try/objdir/mobile make package
> /scratchbox/tools/bin/exec.sh: line 1: cd: build/./try/objdir/mobile: No such file or directory
> make: *** No rule to make target `package'.  Stop.

Here's the corresponding chunk of a good log, for comparison:
> ======== BuildStep started ========
> make package
> === Output ===
> /scratchbox/moz_scratchbox -p -d /scratchbox/users/cltbld/home/cltbld/build/objdir/mobile make package
>  in dir /builds/slave/sendchange-maemo-hg/build (timeout 1200 secs)
>  watching logfiles {}
>  argv: ['/scratchbox/moz_scratchbox', '-p', '-d', '/scratchbox/users/cltbld/home/cltbld/build/objdir/mobile', 'make package']
>  environment:
[SNIP]
>  using PTY: True
> eval eval /builds/scratchbox/sbin/chroot-uid /builds/scratchbox/users/cltbld /scratchbox/tools/bin/env - $SBENV /scratchbox/tools/bin/bash -l /scratchbox/tools/bin/exec.sh /scratchbox/users/cltbld/home/cltbld/build/objdir/mobile make package
> make[1]: Entering directory `/scratchbox/users/cltbld/home/cltbld/build/objdir/mobile/mobile/installer'
> make export
[...]

Note in particular the difference in directory for "objdir/mobile" -- the bad log uses "build/./try/objdir/mobile", whereas the good log uses "/scratchbox/users/cltbld/home/cltbld/build/objdir/mobile".

Comment 1

[Aki Sasaki (not active)]

=(
My fault for not testing the last fix fully.

Comment 2

[Daniel Holbert [:dholbert]]

Sounds like you might have an idea about what's going on, though, which is great! :)

Maybe you already know this, but just in case -- something similar seems to be happening on WinMo, too:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1266962017.1266966170.16586.gz
WinMo try hg build on 2010/02/23 13:53:37

Snippet of Full Log:
> ======== BuildStep started ========
> make package failed
> === Output ===
> make package
>  in dir e:\builds\sendchange-slave\winmo-hg\build/try/objdir/mobile (timeout 1200 secs)
>  watching logfiles {}
>  argv: ['make', 'package']
>  environment:
[SNIP]
>  using PTY: False
> make: *** No rule to make target `package'.  Stop.
> program finished with exit code 2
> elapsedTime=0.125000
> === Output ended ===
> ======== BuildStep ended ========

Comment 3

[Aki Sasaki (not active)]

Yup. Fixing my previous patch, then testing on try-staging, so it'll be red for a bit.

Comment 4

[Aki Sasaki (not active)]

Attachment: allow maemo/winmo factories to specify a different objdir in addPackageSteps()

Things are looking promising, but I'm still waiting for at least Maemo on staging Try.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 428599 [details] [diff] [review]
allow maemo/winmo factories to specify a different objdir in addPackageSteps()

I think bhearsum's feeling left out of my patch review request flood.

I was able to get winmo+maemo builds to work on sm02, and maemo try to work on staging-try-master.  For some reason I couldn't get try-w32-slave05 to connect so I didn't test the winmo part on try, but things are looking good.

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 428599 [details] [diff] [review]
allow maemo/winmo factories to specify a different objdir in addPackageSteps()

For reference: these were the packaging steps before: http://hg.mozilla.org/build/buildbotcustom/rev/e1adbcbb0de0 )

Comment 7

[Aki Sasaki (not active)]

Have a new patch that I'm going to test in staging to address bhearsum's nits (via irc).

Comment 8

[Aki Sasaki (not active)]

Attachment: set objdirPath as class variable

As bhearsum asked, I moved objdir[Path] from a function-level to a class-level variable.

For scratchbox I needed objdirRelPath and objdirAbsPath.  We may need an objdirScratchboxAbsPath, but for now hardcode /home/cltbld/...

Tested winmo/maemo builds on staging and maemo on Try staging (try-w32-slave05 is still MIA) though I definitely had to keep tweaking things on the try factory side to get things working.

Patch 1 of 2.

Comment 9

[Aki Sasaki (not active)]

Attachment: configs part

Update the try maemo baseBuildDir -> build, to fix the try maemo objdirRelPath.
Since bhearsum is on PTO next week, -> catlee =)

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 429277 [details] [diff] [review]
configs part

http://hg.mozilla.org/build/buildbot-configs/rev/b6394bcac20a

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 429276 [details] [diff] [review]
set objdirPath as class variable

http://hg.mozilla.org/build/buildbotcustom/rev/d3915cfb94fd

I oopsed on the -configs checkin comment =P

Comment 12

[Aki Sasaki (not active)]

Hoping this one sticks.