548139 - Enable double-click to edit in DOM node viewer

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, enhancement)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

To work like the CSS Rules viewer.

Comment 1

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: cleanup

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: real changes

Comment 3

[[e-mail]]

Comment on attachment 428570 [details] [diff] [review]
real changes

Nit: the previous "cleanup" for this element makes no sense in the context of this patch, since you're changing it anyway. I would have preferred to see:

>         <treechildren id="olAttrBody"
>                       alternatingbackground="true"
>-        />
>+                      ondblclick="viewer.pane.panelset.execCommand('cmdEditEdit');"/>
>       </tree>

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 428568 [details] [diff] [review]
cleanup 

r=sdwilsh

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 428570 [details] [diff] [review]
real changes

r=sdwilsh

Comment 6

[[e-mail]]

(In reply to comment #3)
>(From update of attachment 428570 [details] [diff] [review])
>Nit: the previous "cleanup" for this element makes no sense in the context of
>this patch, since you're changing it anyway. I would have preferred to see:
>>         <treechildren id="olAttrBody"
>>                       alternatingbackground="true"
>>-        />
>>+                      ondblclick="viewer.pane.panelset.execCommand('cmdEditEdit');"/>
>>       </tree>
Although pushing both patches in one commit would have a similar effect.

Comment 7

[Serge Gautherie (:sgautherie)]

Could you merge the patches for checkin?

Comment 8

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: cleanup+realchanges [Checkin: Comment 9]

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 431911 [details] [diff] [review]
cleanup+realchanges
[Checkin: Comment 9]


http://hg.mozilla.org/dom-inspector/rev/052598952e7e