548209 - This query or location currently has no data, while it should.

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Ludovic Hirlimann [:Usul]]

http://crash-stats.mozilla.com/query/query?version=ALL%3AALL&date=&range_value=4&range_unit=weeks&query_search=signature&query_type=contains&query=MimeObject_write&build_id=&process_type=all&do_query=1

Results in two entry results :
1  	 MimeObject_write(MimeObject*, char const*, int, int)  	7 	5  	2  	0  	0  	
2 	@0x0 | @0x0 | nsCOMPtr_base::~nsCOMPtr_base() | COM_MimeObject_write 	1 	1 	0 	0 	0 	

Clicking on the first link which is http://crash-stats.mozilla.com/report/list?query_search=signature&query_type=contains&query=MimeObject_write&date=&range_value=4&range_unit=weeks&process_type=all&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&signature=MimeObject_write%28MimeObject*%2C%20char%20const*%2C%20int%2C%20int%29

Give no results , while the above table says 7 crashes.

Comment 1

[Ludovic Hirlimann [:Usul]]

If I restraint my queries to the thunderbird product I end up with a versy similar first page and then I can get to my results.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 548209

The query for this particular page forces the parameter $product = 'Firefox' when a product has not been specified or when "All" has been selected.  

This patch ensures that $product = 'Firefox' does not get added to the query when a product has not been specified.

I'm not sure why this would have been added in the first place, unless perhaps it was needed for query speed or optimization.

Comment 3

[Austin King [:ozten]]

Comment on attachment 439979 [details] [diff] [review]
Patch 1 for 548209

A 4 week query with no Criteria was too general and would take tens of minutes for Postgres to execute. Users would hit refresh and several of these would stack up, degrading Postgres' performance and looking up crash-stats.

This type of query should require the user be logged in and we should show a progress screen instead of a blank screen where the user hits refresh.

Maybe DB performance has changed and this is no longer an issue. If we test for that in prod, then I'm okay to r+.

Comment 4

[Austin King [:ozten]]

Comment on attachment 439979 [details] [diff] [review]
Patch 1 for 548209

r+, jetlag had me missing the signature in the query. Patch looks good.

Comment 5

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Austin...  Committing...

==

Sending        libraries/MY_SearchReportHelper.php
Transmitting file data .
Committed revision 1966.

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Verified in production.