Closed
Bug 548330
Opened 15 years ago
Closed 14 years ago
stop running pskill and delete it from the slaves
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: rail)
Details
(Whiteboard: [buildslaves][opsi])
Attachments
(2 files)
|
1.59 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
|
2.54 KB,
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
We used to 'pskill' to kill firefox.exe and other processes at the start of a unittest run. With proper Twisted process management and reboots after every build we no longer need it. Additionally, it often causes problems on new slaves because it requires a license to be click-throughed. We should stop running it in UnittestBuildFactory, and delete it from the slaves.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → rail
|
|
Assignee | |
Updated•14 years ago
|
Priority: P5 → P2
|
|
Assignee | |
Comment 1•14 years ago
|
||
I didn't touch CC* classes, they still may want to use pskill.exe.
Attachment #547023 -
Flags: review?(bhearsum)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #547024 -
Flags: review?(bhearsum)
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 547024 [details] [diff] [review]
OPSI package
Review of attachment 547024 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547024 -
Flags: review?(bhearsum) → review+
|
|
Reporter | |
Comment 4•14 years ago
|
||
Comment on attachment 547023 [details] [diff] [review]
buildbotcustom
Review of attachment 547023 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547023 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 547023 [details] [diff] [review]
buildbotcustom
http://hg.mozilla.org/build/buildbotcustom/rev/e4ca4693a43e
Attachment #547023 -
Flags: checked-in+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Comment on attachment 547024 [details] [diff] [review]
OPSI package
http://hg.mozilla.org/build/opsi-package-sources/rev/2e55b2e299a0
Attachment #547024 -
Flags: checked-in+
|
|
Assignee | |
Comment 7•14 years ago
|
||
I generated remove-pskill_1.0-1.opsi package on production-opsi.build.mozilla.org (tested in staging). I will force installation of the package once the buildbotcustom patch is deployed.
|
|
Assignee | |
Comment 8•14 years ago
|
||
OPSI package set to be deployed in staging and production yesterday.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 9•13 years ago
|
||
(In reply to Ben Hearsum from comment #0)
> We used to 'pskill' to kill firefox.exe and other processes at the start of
> a unittest run. With proper Twisted process management and reboots after
> every build we no longer need it. Additionally, it often causes problems on
> new slaves because it requires a license to be click-throughed. We should
> stop running it in UnittestBuildFactory, and delete it from the slaves.
FYI use -accepteula to avoid the click-through, or switch to taskkill.
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•