548330 - stop running pskill and delete it from the slaves

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We used to 'pskill' to kill firefox.exe and other processes at the start of a unittest run. With proper Twisted process management and reboots after every build we no longer need it. Additionally, it often causes problems on new slaves because it requires a license to be click-throughed. We should stop running it in UnittestBuildFactory, and delete it from the slaves.

Comment 1

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

I didn't touch CC* classes, they still may want to use pskill.exe.

Comment 2

[Rail Aliiev [:rail]]

Attachment: OPSI package

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 547024 [details] [diff] [review]
OPSI package

Review of attachment 547024 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 547023 [details] [diff] [review]
buildbotcustom

Review of attachment 547023 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 547023 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/e4ca4693a43e

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 547024 [details] [diff] [review]
OPSI package

http://hg.mozilla.org/build/opsi-package-sources/rev/2e55b2e299a0

Comment 7

[Rail Aliiev [:rail]]

I generated remove-pskill_1.0-1.opsi package on production-opsi.build.mozilla.org (tested in staging). I will force installation of the package once the buildbotcustom patch is deployed.

Comment 8

[Rail Aliiev [:rail]]

OPSI package set to be deployed in staging and production yesterday.

Comment 9

[[e-mail]]

(In reply to Ben Hearsum from comment #0)
> We used to 'pskill' to kill firefox.exe and other processes at the start of
> a unittest run. With proper Twisted process management and reboots after
> every build we no longer need it. Additionally, it often causes problems on
> new slaves because it requires a license to be click-throughed. We should
> stop running it in UnittestBuildFactory, and delete it from the slaves.

FYI use -accepteula to avoid the click-through, or switch to taskkill.