548477 - Core now claims multitouch events in the content area (gestures aka swipe/pinch)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

"I notice three-finger swiping to navigate between current and previous pages is busted on my MBP"

Bug 412486 made ChildView capture multitouch events; bug 412486 comment 46 describes what we need to do to be able to access them again.

Comment 1

[mike smith]

Multitouch gestures do work within the chrome portions of the browser -- toolbar, bookmark bar, etc. They do not work in the main browser window on my MBP, running Version 2.1a1pre on OS X 10.6.4.

Comment 2

[Sean Murphy]

Attachment: Swipe Support

Hey Gang,

Long time no see! I am trying out some of the 1.9.2 builds lately, as I've been bummed having to choose between new HTML5/CSS3 web features and Camino.  I noticed swipe back/forward was broken when it occurred in the browser content area, and I missed this feature.  Thankfully I was able to find time to work on a patch for the first time in a while :).

The patch only adds support for swiping left and right - I didn't have time to implement anything for pinching yet, but that shouldn't be any more difficult.  I wasn't sure who to target a review against these days, but I'll make sure to find time to address any issues with the patch.

Great to contribute again, I definitely miss not doing so on a regular basis lately and especially communicating with you all.  Hope everything is well.  I'll have to hop onto chat eventually!

- Murph

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

A classic murph patch: out of the blue! :D

Since Sean's got the patch here for swipe, and since missing gestures is one of the most common issues mentioned by nightly users, pulling this over to a1? while we wait on bug 506345.  Ideally we'd get pinch, too, for a1, but I imagine that for gesture users, this is a good start.

Comment 4

[Stuart Morgan]

Comment on attachment 458249 [details] [diff] [review]
Swipe Support

Looks pretty good, but as long as we are going to have BWC implement the gestures too (which I think we still want, so gestures work while chrome is focused) the events need to be bounced up another level via BrowserUIDelegate, so the implementations can be shared. We'll need a non-core enum for swipe direction for it to use, and then both BrowserWrapper and the existing BWC swipe handler can convert to that enum and call through.

Thanks for the patch :)

Comment 5

[Sean Murphy]

Attachment: Swipe Support v2

Updated to address the previous suggestions.

Thanks Stuart for the review.  Sorry it took me a little while to refresh the patch!

Comment 6

[Stuart Morgan]

Comment on attachment 472267 [details] [diff] [review]
Swipe Support v2

Perfect, thanks :) r=me

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 472267 [details] [diff] [review]
Swipe Support v2

sr=pink

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/1e5793bf6d40

Thanks, Sean!  Leaving this open in anticipation that you'll get to pinch-to-zoom in a bit, too.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per the meeting, we're not blocking 2.1a1 on pinch-to-zoom, but we'll continue to take patches as we finish off the infra issues ahead of the release.

Comment 10

[Daniel Egger]

Pinch to Zoom worked just fine in 2.0.7 on both SL and Lion, in 2.1b1 it's broken. :/

Comment 11

[Stuart Morgan]

Yes, that's why we opened a bug.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Stuart Morgan from comment #11)
> Yes, that's why we opened a bug.

In particular, why this bug is still open.  It's targeted at Camino 2.1, so we should fix it for the final 2.1 release.

I've looked at this a few times, and it's probably something I could fix, but I don't have the hardware, so I'd be writing GeckXPCOM C++ blindly (and, unlike when Stuart wrote the original patch, I also don't have a guy in the next cube whose Air I could borrow to test).

Comment 13

[Daniel Egger]

I'd be willing to test that bugger. I've never actually tried to compile Camino before and my last (successful) SeaMonkey run was a couple of years back but since my profession includes getting fancy stuff to compile... ;)

Comment 14

[Stuart Morgan]

I have multitouch capable hardware, so this is on my mental list of things I'm hoping to have time to tackle. I haven't taken it yet because I'm not sure how much time I'll have.

Comment 15

[Stuart Morgan]

Attachment: Pinch Support

This was indeed pretty straightforward thanks to the structure set up by murph's patch.

Comment 16

[Stuart Morgan]

Landed as http://hg.mozilla.org/camino/rev/ccfbabfea9c1