548608 - incorrect font fallback behavior for some scripts/languages

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

See bug 524107 comments 34-37: selection of fallback fonts for Chinese-TW and possibly other languages is incorrect since the landing of bug 524107.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: patch, v1 - update Windows font list to work with atom language codes

This was missed in my patch for bug 524107: the Windows override of SupportsLangGroup simply gets ignored because it's not using the updated parameter type.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Can we have a test for this?

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: patch, v2 - update Windows font list to work with atom language codes (corrected)

Fixed the patch to actually build properly.

Comment 4

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/mozilla-central/rev/c2ed18018054

Comment 5

[Ziru]

The font fallback behavior might not be completely fixed, since some pages in zh-CN still looks bad.  By the way, the font in tab title is always incorrect.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a2pre) Gecko/20100226 Minefield/3.7a2pre (.NET CLR 3.5.30729)

Comment 6

[Jonathan Kew [:jfkthame]]

(In reply to comment #5)
> The font fallback behavior might not be completely fixed, since some pages in
> zh-CN still looks bad.  By the way, the font in tab title is always incorrect.

If you could provide a specific testcase, along with screenshots of correct and incorrect display, that would be helpful.

Comment 7

[wiiwaker]

Attachment: font fallback still behaves incorrectly in tab and bookmark titles

Comment 8

[wiiwaker]

I have added the screenshots, the upper one is correct.
The test website is http://www.mozillaonline.com/. When in Firefox 3.6 with a clean profile, the tab and bookmark titles display in "Microsoft YaHei" font after setting the default font to the former. But in these days' nightly builds with the same profile, the title displays in some other font.

Comment 9

[Ziru]

Attachment: Correct fonts displayed in FF3.6

Comment 10

[Ziru]

Attachment: Incorrect fonts displayed in FF3.7 nightlies

Comment 11

[Ziru]

(In reply to comment #6)
> (In reply to comment #5)
> > The font fallback behavior might not be completely fixed, since some pages in
> > zh-CN still looks bad.  By the way, the font in tab title is always incorrect.
> 
> If you could provide a specific testcase, along with screenshots of correct and
> incorrect display, that would be helpful.

I have uploaded two screenshots of correct (in FF3.6) and incorrect display (in recent FF3.7 nightlies) for the same web page (using the same FF profile).  I have no idea of how to provide a specific test case for this issue.