Closed
Bug 548646
Opened 14 years ago
Closed 14 years ago
Permission manager getter in Services.jsm should be more descriptive
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
|
7.77 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Unless you already know what it is, "Services.pm" or "Services.pm.add()" isn't very descriptive. There's already a Services.prefs (for the pref service), so renaming .pm to .perms would make things both more readable and consistent.
Attachment #428986 -
Flags: review?(gavin.sharp)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 428986 [details] [diff] [review] Patch v.1 >diff --git a/toolkit/content/tests/browser/browser_Services.js b/toolkit/content/tests/browser/browser_Services.js >+ ok(Services.perms instanceof Ci.nsIPermissionManager, "Services.pm is an nsIPermissionManager"); Fix the test message too?
Attachment #428986 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/633a33a635f3
Assignee: nobody → dolske
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
You need to log in
before you can comment on or make changes to this bug.
Description
•