Missing python version check in configure

RESOLVED FIXED

Status

MailNews Core
Build Config
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Martin Stránský, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.4})

1.9.1 Branch
fixed-seamonkey2.0.4
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.0 .4-fixed)

Details

(Whiteboard: [fixed by bug 427750], URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
We may missing a minimal suitable python version check in configure script like firefox has. For instance it fails with:

/usr/bin/python ../toolkit/xre/make-platformini.py --print-buildid > buildid
Traceback (most recent call last):
  File "../toolkit/xre/make-platformini.py", line 4, in ?
    from datetime import datetime
ImportError: No module named datetime

with python-2.2.3-6.11
(Assignee)

Comment 1

8 years ago
m-1.9.1 doesn't have such a check (yet). Moving to trunk (m-1.9.2+).

What command do you run to get this error?
What result do you get if you try "the same" directly from m-c?
How do you pass c-c client.py check?
Assignee: nobody → sgautherie.bz
Blocks: 506493
Severity: normal → trivial
Status: NEW → ASSIGNED
Component: Build Config → Build Config
Depends on: 427750
Flags: in-testsuite-
OS: Linux → All
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Hardware: x86 → All
Version: SeaMonkey 2.0 Branch → Trunk
(Reporter)

Comment 2

8 years ago
Here we come. There is the command which launches the build. python-2.2.3-6.11, RHEL-3. 

$make -f client.mk build STRIP=/bin/true MOZ_MAKE_FLAGS=-j2
Adding client.mk options from /usr/src/redhat/BUILD/seamonkey-2.0.3/comm-1.9.1/.mozconfig:
    BUILD_OFFICIAL=1
    MOZILLA_OFFICIAL=1
make[1]: Entering directory `/usr/src/redhat/BUILD/seamonkey-2.0.3/comm-1.9.1'
cd /usr/src/redhat/BUILD/seamonkey-2.0.3/comm-1.9.1
./configure
Adding configure options from ./.mozconfig:
  --enable-application=suite
  --prefix=/usr
  --libdir=/usr/lib
  --without-system-nspr
  --without-system-nss
  --with-system-jpeg
  --with-system-zlib
  --with-pthreads
  --disable-tests
  --disable-installer
  --disable-debug
  --enable-optimize=-O2 -g -pipe -march=i386 -mcpu=i686
  --enable-xinerama
  --enable-default-toolkit=cairo-gtk2
  --disable-xprint
  --disable-strip
  --enable-pango
  --disable-system-cairo
  --enable-svg
  --enable-canvas
  --enable-extensions=default,irc
  --enable-crypto
  --enable-safe-browsing
  --disable-crashreporter
  --enable-static
  --disable-system-hunspell
  --disable-dbus
  --disable-ogg
  --disable-wave
(Reporter)

Comment 3

8 years ago
Created attachment 429071 [details]
complete build log
(Reporter)

Updated

8 years ago
Attachment #429071 - Attachment is patch: false
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> complete build log

All configures ran fine: the error happens when starting to actually "make" 'mozilla'.
{
[...]
/usr/bin/gmake -C mozilla default
gmake[2]: Entering directory `/usr/src/redhat/BUILD/seamonkey-2.0.3/comm-1.9.1/mozilla'
[...]
/usr/bin/python ../toolkit/xre/make-platformini.py --print-buildid > buildid
Traceback (most recent call last):
  File "../toolkit/xre/make-platformini.py", line 4, in ?
    from datetime import datetime
ImportError: No module named datetime
gmake[5]: *** [export] Error 1
}

Moving back to 1.9.1: this "just" needs bug 427750 to land on m-1.9.1 too...
No longer blocks: 506493
Severity: trivial → minor
Whiteboard: [will be fixed by bug 427750]
Version: Trunk → 1.9.1 Branch
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
status-thunderbird3.0: --- → .4-fixed
Resolution: --- → FIXED
Whiteboard: [will be fixed by bug 427750] → [fixed by bug 427750]
Verified fixed on TB 3 as bug 427750 hasn't broken / affected the builds.
Keywords: verified-thunderbird3.0

Updated

8 years ago
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.