548712 - optimize Mac OS X native menu image code

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

Attachment: fix v1.0

There are some optimizations we can make to the code that creates images for Mac OS X native menus.

* Avoid unnecessary endian swaps
* Avoid unnecessary ARGB->RGBA conversion
* Avoid unnecessary an unnecessary malloc and image copy when we don't need a sub-image

Comment 1

[Josh Aas]

There is probably some other optimization we could do but this cleans up the worst of it I think. In Firefox the menu images tend to not require a sub-image so we do actually cut out the sub-image copy in most cases.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 429039 [details] [diff] [review]
fix v1.0

Looks fine to me.

Comment 3

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/9dbbcdec2199

Comment 4

[Alfred Kayser]

I assume that there is more to optimize here, when the (sub)image is already 16x16:
498   // The image may not be the right size for a menu icon (16x16).
499   // Create a new CGImage for the menu item.
500   PRUint8* bitmap = (PRUint8*)malloc(kIconBytes);