548983 - Option Dialog choice wrong font when DirectWrite Enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.3a2pre) Gecko/20100226 Minefield/3.7a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.3a2pre) Gecko/20100226 Minefield/3.7a2pre

When default font is no ASCII name(ex. メイリオ,ＭＳ Ｐゴシック), 
Option Dialog choice wrong font or no choice.

Reproducible: Always

Steps to Reproduce:
1. disable DirectWrite and restart Fx
2. open OptionDialog
3. click content
4. set Default Font with no ASCII name
5. enable DirectWrite and restart Fx
6. open OptionDialoig

Actual Results:  
Default font is wrong font

Expected Results:  
show selected font

Comment 1

[ICHIMARU Takeshi(a.k.a. Ayakawa)]

Attachment: Option Dialog GDI ver. and DirectWrite ver.

Comment 2

[Bas Schouten (:bas.schouten)]

(In reply to comment #1)
> Created an attachment (id=429257) [details]
> Option Dialog GDI ver. and DirectWrite ver.

Hrm, I though we fixed this! Any idea where this was broken again John?

Comment 3

[John Daggett (:jtd)]

Attachment: patch, v0.1, define GetStandardFamilyName

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=429257) [details] [details]
> > Option Dialog GDI ver. and DirectWrite ver.
> 
> Hrm, I though we fixed this! Any idea where this was broken again John?

Yup, I included a patch (bug 527707, comment 161) that fixed it but you never put it into your patch.  Just need to define gfxDWriteFontList::GetStandardFamilyName.

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 429375 [details] [diff] [review]
patch, v0.1, define GetStandardFamilyName

>diff --git a/gfx/thebes/src/gfxDWriteFontList.cpp b/gfx/thebes/src/gfxDWriteFontList.cpp
>--- a/gfx/thebes/src/gfxDWriteFontList.cpp
>+++ b/gfx/thebes/src/gfxDWriteFontList.cpp
>@@ -514,8 +514,22 @@ gfxDWriteFontList::InitFontList()
>                     nsDependentString(famName.Elements()),
>                     family);
>             fontList->mFontFamilies.Put(name, fam);
>         }
>     }
> 
>     StartLoader(kDelayBeforeLoadingFonts, kIntervalBetweenLoadingFonts);
> }
>+
>+

Looks good to me! Seems like we should only need one newline here though?

Comment 5

[John Daggett (:jtd)]

Pushed to trunk
http://hg.mozilla.org/mozilla-central/rev/16e2bf477e1b