Closed
Bug 549065
Opened 15 years ago
Closed 15 years ago
Could not get glyph extents (no aContext) warnings displaying SVG text with direct2d
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: longsonr, Assigned: longsonr)
References
Details
Attachments
(1 file)
|
4.53 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
an alternative would be to make the called code work with null without displaying warnings but I don't know whether that is advisable.
Attachment #429305 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•15 years ago
|
||
gfxGlyphExtents::GetTightGlyphExtentsAppUnits prints the warning
Summary: Could not get glyph extents warnings displaying SVG text with direct2d → Could not get glyph extents (no aContext) warnings displaying SVG text with direct2d
|
||
Updated•15 years ago
|
Attachment #429305 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
|
||
Updated•15 years ago
|
Assignee: nobody → longsonr
Actually I'm a bit uncomfortable with this patch. Passing down the computational image surface is not necessarily the right thing to do ... the actual glyph metrics could be adjusted based on the output target. We should be trying to use an actual surface we'd draw to.
Why are we only hitting this warning with D2D?
|
|
||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 4•15 years ago
|
||
It's gone away now. Perhaps some d2d change has fixed it.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•