Closed Bug 54916 Opened 26 years ago Closed 25 years ago

Define MOZILLA_CLIENT optionally (and per default)

Categories

(SeaMonkey :: Build Config, defect, P3)

Sun
Solaris
defect

Tracking

(Not tracked)

VERIFIED WONTFIX
mozilla0.9.1

People

(Reporter: axel, Assigned: axel)

Details

Attachments

(2 files)

Hi, giving modules the possibility to undefine MOZILLA_CLIENT makes it easier to create standalone packages. This is needed to get rid of the expat copy in extensions/transformiix, as we need a build without MOZILLA_CLIENT for the standalone version. I will attach a patch, cls, leaf, please review. I added a default define for MOZILLA_CLIENT, and switch that off, if the built module is transformiix. The OS_COMPILE_CFLAGS and OS_COMPILE_CXXFLAGS in autoconf.mk are unchanged for my config for a complete build. Axel
+ if test "$BUILD_MODULES" = "transformiix"; then + MOZILLA_CLIENT= + fi] ) That's only going to catch the case of --enable-modules=transformiix . If you add ",dbm" to that list, the test will fail.
Status: NEW → ASSIGNED
Hi Chris, the test for building only transformiix was intentional. I don't know if we want to support several standalone modules built in one tree. So, to be sure to have this without sideeffects, I switch off MOZILLA_CLIENT only for (pure) transformiix standalone builds. Axel
We do want to support multiple standalone modules in a single tree. Wouldn't the build break in the "transformiix,dbm" case because expat will not be built correctly?
So how about getting this in, or corrected (if there are still objections). We'd like to turn XSLT on in the near future. We'll then probably have a flag to disable it (--disable-xslt whatever...), which would unset MOZ_XSL for us. That would lead to the silly situation where you need to add --disable-xslt to build the standalone transformiix. If we can switch to MOZILLA_CLIENT (instead of MOZ_XSL), and be able to turn it off for the standalone version the world would be a better place :-). So we're looking for an r, please.
Target Milestone: --- → mozilla0.9
Blocks: 72141
pushing back :-(
Target Milestone: mozilla0.9 → mozilla0.9.1
No longer blocks: 72141
marking wontfix, as transformiix standalone intends to work around this. filed bug 81414 for that
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: