549184 - A line box containing an inline element with padding is rendered as zero height

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[Bruno Fassino]

Attachment: An empty inline element with padding, alone on a line box

The testcase is rendered differently in: 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a2pre) Gecko/20100227 Minefield/3.7a2pre (.NET CLR 3.5.30729)

and in:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6

Essentially a 
<div><span style="padding-left: 1em"></span></div>
is now rendered as zero height, which I don't think is correct.

The same occurs with margin instead of padding.

Comment 1

[philippe (part-time)]

regression between 20100201 and 20100202 builds
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f57b95afb57e&tochange=f557921b88a7

from bug 538935 ?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Almost certainly, yes.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This backs out the patch for bug 538935, reverting LineIsEmpty to mean that all frames on the line return true for nsIFrame::IsEmpty. Then we refix bug 538935 by adding a new flag that is set when all non-span frames on the line are empty.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 429469 [details] [diff] [review]
fix

r=dbaron

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Though, one thing I'm worried about:  do we depend on TEXT_START_OF_LINE being set during intrinsic width computation?   That happens before reflow.  (I guess if we do, it's an existing problem, though.)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #5)
> Though, one thing I'm worried about:  do we depend on TEXT_START_OF_LINE being
> set during intrinsic width computation?

I don't think we do.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/58864f51e68e