54921 - crash while dismissing default downloader plugin

Status: VERIFIED DUPLICATE of bug 76505

(Core Graveyard :: Plug-ins, defect, P3)

Description

[uamjet602]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.12-20 i686; en-US; m18) Gecko/20001002
BuildID:    2000100208

When I go to a page that contains something that needs a plugin, I get the
plugin downloader plugin. Sometimes when I dismiss it, Mozilla crashes. The
console sais:

Gdk-ERROR **: BadWindow (invalid Window parameter)
serial 347 error_code 3 request_code 1 minor_code 0

Reproducible: Sometimes
Steps to Reproduce:
1. Go to the URL
2. dismiss the dialog that pops up.
3. It pops up again and again, keep dismissing it.
4. crash (sometimes)			

Actual Results:  Mozilla crashed					

Expected Results:  The dialog goes away and stays away				

This seems a bit like bug 44711 , but that was before the real default plugin
downloader plugin was there. Also this states the GTK error, which that one doesn't

Comment 1

[av (gone)]

Stephen, would you look at this?

Comment 2

[Marcello Nuccio]

Tried with linux build 100214: it pops up again and again while I press
the `Cancel' button, but no crash occur until I press the `OK' button.

Comment 3

[Luis Villa]

Confirming. This definitely crashes my browser, as described by Marcello.

Comment 4

[ekrock's old account (dead)]

Nominating for rtm consideration. Stephen, any chance you could fix this in time
for N6 RTM? It's a serious concern if our default plug-in is causing crashes.
(Remember not to mention specific dates within the public bug report.)

Comment 5

[shrirang khanzode]

dup of 55261.

*** This bug has been marked as a duplicate of 55261 ***

Comment 6

[uamjet602]

This is not a duplicate. Bug 55261 talks about the dialog coming back after 
being dismissed, and about mozilla seeming to hang because the (modal) dialog 
is hidden. Not about crashing.

Adding crash keyword, requesting reopen.

Comment 7

[shrirang khanzode]

That's what your steps above say :
>dismiss the dialog that pops up.
>3. It pops up again and again, keep dismissing it.
>4. crash ***(sometimes)***        

If you disagree, pls reopen.

Comment 8

[uamjet602]

I retested it (2000102508) and it still crashes. Reopened and added dependency
for bug 55261.

Comment 9

[Stephen Mak]

sorry for replying late. I tried on my pr3 build on solaris, it doesn't 
crash... can anyone give some specific url to try out? i tried the apple/quick
time page. 

Comment 10

[Stephen Mak]

i don't see this crash occur in my solaris pr3 experience. also, my guess 
this crash is related to the gtk window creation (request code=1) and the
parent window id is unknown. Don't have any idea to fix it in my head and
think should not drag down the n6 release (unless people can reproduce 
the bug in a very easy way which cause n6 crashes a lot).

Comment 11

[Asa Dotzler [:asa]]

*** Bug 59922 has been marked as a duplicate of this bug. ***

Comment 12

[R.K.Aa.]

*** Bug 65524 has been marked as a duplicate of this bug. ***

Comment 13

[ekrock's old account (dead)]

Marking pp as this is a Linux-specific crash and 4xp as this would cause pages
that worked in Nav4 when the user lacked the plug-in to crash when viewed in
Nav6. Nom. nsbeta1 as pp crasher.

Comment 14

[shrirang khanzode]

I do not see a dialog pop-up anymore on the linux branch/trunk. tinus_mozilla, 
can you pls check ? thanks!

Comment 15

[Barrett Lindstrom]

*** Bug 66690 has been marked as a duplicate of this bug. ***

Comment 16

[R.K.Aa.]

another plugin downloader crash when user hits OK is in bug 67879

Comment 17

[karnaze (gone)]

Marking mozilla0.9. Stephen, if you don't have time to fix this within the next 
4 weeks, please reassign to av.

Comment 18

[av (gone)]

cc'ing serge

Comment 19

[Asa Dotzler [:asa]]

Are you still shooting for 0.9 on this? If so please email [e-mail]
with a status on you progress. If not please retarget against a later Milestone.
Thanks.

Comment 20

[serge (gone)]

I would say this is a dup of 76505 or vice versa,
at least I think my proposal patch for 76505 will fix this one also.

Comment 21

[chris hofmann]

*** This bug has been marked as a duplicate of 76505 ***

Comment 22

[Chad Austin]

Lots of verifications.

If I had to test stuff, it was on Win2K, build id 2001052404.