mozilla.widget.render-mode should be initialized in all.js

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jtd, Assigned: bas)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
gfxWindowsPlatform::gfxWindowsPlatform reads in a pref 'mozilla.widget.render-mode', used for rendering.  The defaults are set here:

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/src/gfxWindowsPlatform.cpp#121

This logic should be in all.js also.
(Assignee)

Comment 1

8 years ago
This has never been the case in the past, although I'm not sure why. Is there a reason this wasn't done in the past, and if so, should we change it?
(Assignee)

Comment 2

8 years ago
Created attachment 429774 [details] [diff] [review]
Initialize mozilla.widget.render-mode
Attachment #429774 - Flags: review?(vladimir)
Comment on attachment 429774 [details] [diff] [review]
Initialize mozilla.widget.render-mode

This is wrong, it should be initialized to -1 -- the default is different per platform at build time.
Attachment #429774 - Flags: review?(vladimir) → review-
(Assignee)

Comment 4

8 years ago
Created attachment 429866 [details] [diff] [review]
Initialize mozilla.widget.render-mode properly
Attachment #429774 - Attachment is obsolete: true
Attachment #429866 - Flags: review?(vladimir)
(Assignee)

Comment 5

8 years ago
Pushed changeset a258698d412f.
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

8 years ago
Backed out
http://hg.mozilla.org/mozilla-central/rev/56c1507450be

Caused assertions to fire during mochitests:
###!!! ASSERTION: Invalid RenderMode!: 'Error', file e:/builds/moz2_slave/mozilla-central-win32-debug/build/widget/src/windows/nsWindowGfx.cpp, line 503
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
That would be due to bug 549668.
Depends on: 549668
Re-landed this along with bug 549668.
http://hg.mozilla.org/mozilla-central/rev/8871f153c651
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.