Closed
Bug 549311
Opened 14 years ago
Closed 14 years ago
New lines management tests for placeholder are missing
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.61 KB,
patch
|
Details | Diff | Splinter Review |
Specification says new lines should not be shown in the placeholder. It has been implemented correctly in bug 457800 but I forgot to write tests for that. Ehsan, could you review those tests ?
Attachment #429520 -
Flags: review?(ehsan.akhgari)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 429520 [details] [diff] [review] Patch v0.1 >diff -r 3874a469cf09 layout/reftests/forms/placeholder/placeholder-11.html >--- /dev/null Thu Jan 01 00:00:00 1970 +0000 >+++ b/layout/reftests/forms/placeholder/placeholder-11.html Mon Mar 01 16:14:40 2010 +0100 >@@ -0,0 +1,8 @@ >+<!DOCTYPE html> >+<html> >+ <!-- Test: placeholder shouldn't show new lines --> >+ <body> >+ <input type="text" value="" placeholder="my >+ placeholder"> I think it's better if you use HTML numeric entities here. r=me with that fixed.
Attachment #429520 -
Flags: review?(ehsan.akhgari) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
The new patch with the modifications asked by ehsan. r=ehsan
Attachment #429520 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9d313a2e3d79
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a3
You need to log in
before you can comment on or make changes to this bug.
Description
•