Closed
Bug 549349
Opened 14 years ago
Closed 14 years ago
file drop URIs only accidentally work
Categories
(Core :: DOM: Copy & Paste and Drag & Drop, defect)
Core
DOM: Copy & Paste and Drag & Drop
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a3
People
(Reporter: Gavin, Assigned: Gavin)
Details
(Keywords: verified1.9.0.19, verified1.9.1, verified1.9.2)
Attachments
(1 file)
|
2.46 KB,
patch
|
mossop
:
review+
beltzner
:
approval1.9.2.2+
beltzner
:
approval1.9.1.9+
beltzner
:
approval1.9.0.19+
|
Details | Diff | Splinter Review |
The security check we do in dragDropSecurityCheck doesn't explicitly allow drops of file URIs - they just happen to work because in most cases the source document is null. We should fix that to avoid problems in the future.
|
Assignee | |
Comment 2•14 years ago
|
||
|
||
Updated•14 years ago
|
Attachment #429551 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66b74d46682e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → mozilla1.9.3a2
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: mozilla1.9.3a2 → mozilla1.9.3a3
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 429551 [details] [diff] [review] patch Wouldn't hurt to get this on branches too.
Attachment #429551 -
Flags: approval1.9.2.2?
Attachment #429551 -
Flags: approval1.9.1.9?
Attachment #429551 -
Flags: approval1.9.0.19?
|
||
Comment 5•14 years ago
|
||
Comment on attachment 429551 [details] [diff] [review] patch a=beltzner for 1.9.2.2, 1.9.1.9. 1.9.0.19
Attachment #429551 -
Flags: approval1.9.2.2?
Attachment #429551 -
Flags: approval1.9.2.2+
Attachment #429551 -
Flags: approval1.9.1.9?
Attachment #429551 -
Flags: approval1.9.1.9+
Attachment #429551 -
Flags: approval1.9.0.19?
Attachment #429551 -
Flags: approval1.9.0.19+
|
|
Assignee | |
Comment 6•14 years ago
|
||
1.9.2: https://hg.mozilla.org/releases/mozilla-1.9.2/rev/82fa604cdf23 1.9.1: https://hg.mozilla.org/releases/mozilla-1.9.1/rev/ff4a52b1c2a4 1.9.0: mozilla/toolkit/content/nsDragAndDrop.js 1.11
|
||
Comment 7•14 years ago
|
||
How can qa verify this? also, are there unit tests?
|
|
||
Comment 8•14 years ago
|
||
Patch was fixed in another bug that has been marked verified on verified1.9.0.19, verified1.9.1, verified1.9.2. resolving here also.
You need to log in
before you can comment on or make changes to this bug.
Description
•