549415 - Remove GetNativeGraphicData()

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

There are only four callers.
1. nsNativeThemeWin.cpp which will perhaps be dealt with in bug 549110
2. nsVideoFrame.cpp which will go away after bug 549331
3-4. two other users in nsObjectFrame.cpp used only on OS/2 for printing plugins.

Peter can you get rid of the OS/2 users?

Comment 1

[Peter Weilbacher]

From what I remember plugin printing never worked in the past year(s), so removing the OS/2 stuff should be simple.

Hmm, wait, one use is in nsObjectFrame::PaintPlugin(). Removing that might be some work. I'm not really up to date: what's the replacement to get native objects?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #1)
> Hmm, wait, one use is in nsObjectFrame::PaintPlugin(). Removing that might be
> some work. I'm not really up to date: what's the replacement to get native
> objects?

All of the other platforms have gfxWindowsNativeDrawing type class. So you should create a gfxOS2NativeDrawing class and use that.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Caller (1) in comment 0 died in bug 585817.

Comment 5

[Peter Weilbacher]

So, by now only the OS/2 use holds this up.
I looked at this briefly in March but without quick success and no time since then. Rich, any chance you can do this?

Hmm, should not a simple
   HPS hps = static_cast<gfxOS2Surface*>(static_cast<gfxASurface*>(surf.get()))
             ->GetPS();
work instead of the call to GetNativeGraphicData()? That's the only thing that that function does for us that's not already in the code in nsObjectFrame::PaintPlugin(). (I cannot build/test on OS/2 at the moment.)

Comment 6

[Atul Aggarwal]

I could not find any reference of GetNativeGraphicData() in nsObjectFrame.cpp file. Am I missing something or is this bug already resolved?

Comment 7

[Josh Matthews [:jdm]]

MXR shows no results for getnativegraphicdata.