549536 - nsPrivateBrowsingService.js should use nsICookieManager2.getCookiesFromHost

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[[e-mail]]

http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/src/nsPrivateBrowsingService.js#583

Using nsICookieManager.enumerator means iterating over all cookies, of which there will be thousands. This is slow -- much better to just do

  cm.getCookiesFromHost(aDomain);

and then the guard on 'hasRootDomain' isn't required, either.

Comment 1

[(no longer active)]

So, does GetCookiesFromHost expose the exact same behavior as what we achieve using hasRootDomain?  (i.e., we want clearing cookies for mozilla.org also clear all cookies for xyz.mozilla.org, abc.xyz.mozilla.org, etc. as well).

Comment 2

[[e-mail]]

Yes. :)

Comment 3

[(no longer active)]

One more question, should we pass a preceding dot with the domain name to GetCookiesFromHost?

Comment 4

[[e-mail]]

It doesn't matter, but let's say no.

Comment 5

[(no longer active)]

Attachment: Patch (v1)

Comment 6

[(no longer active)]

This _was_ a good first bug, but since it would potentially lead to perf wins, I decided to pick it up myself. :-)

Comment 7

[[e-mail]]

Comment on attachment 432683 [details] [diff] [review]
Patch (v1)

r=dwitte -- I assume that's OK, given that I wrote the API. :)

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f94b5b994710