549795 - search-and-replace removal of backward compatibility string typedefs in layout/

Status: NEW

(Core :: Layout, defect)

Description

[Zack Weinberg (:zwol)]

Attachment: patch

This patch removes all uses of the "backward compatibility" string typedefs in layout. It was mostly done mechanically, with these commands:

$ cd layout
$ grep -Ewrl 'nsC?Substring|nsAFlatC?String|nsASingleFragmentC?String' * |
  xargs perl -pi -e '
    s/\bnsSubstring\b/nsAString/g;
    s/\bnsASingleFragmentString\b/nsAString/g;
    s/\bnsCSubstring\b/nsACString/g;
    s/\bnsASingleFragmentCString\b/nsACstring/g;
    s/\bnsAFlatString\b/nsString/g;
    s/\bnsAFlatCString\b/nsCString/g'

I then manually inspected the result and fixed up a few places where this threw off the indentation.

Since typedefs are just aliases, I don't believe IID bumps should be required.

Comment 1

[Zack Weinberg (:zwol)]

Note to enthusiastic people: that command is _not_ safe at top level.  It's _probably_ safe in all top-level directories except xpcom, but I didn't look that hard.  It's not my itch, outside layout. :)

Comment 2

[Zack Weinberg (:zwol)]

Comment on attachment 429915 [details] [diff] [review]
patch

changed reviewer to bsmedberg since bz disclaims knowledge of the current preferred string nomenclature.

Comment 3

[Zack Weinberg (:zwol)]

For the record: I have been going by http://mxr.mozilla.org/mozilla-central/source/xpcom/string/public/nsStringFwd.h#84 which lists the removed names as "backward compatibility typedefs".

Comment 4

[Benjamin Smedberg]

Comment on attachment 429915 [details] [diff] [review]
patch

Cancelling review for now since I don't think we've decided whether nsSubstring or nsAString is actually the better name... AString has more history behind it, but substring is somewhat clearer.

Comment 5

[Zack Weinberg (:zwol)]

If the only difference between nsString and nsAString is that the latter is not guaranteed to be nul-terminated, then I don't think either of "nsAString" nor "nsSubstring" conveys that distinction at a glance.  nsSubstring puts me more in mind of what (as I understand it) nsDependentString does.

Comment 6

[Zack Weinberg (:zwol)]

I no longer work for Mozilla, I am deassigning myself from bugs I have no intention of working on as a volunteer.