Closed Bug 549797 Opened 14 years ago Closed 14 years ago

Removing href attribute from html:a, html:link, and svg:a doesn't remove link styling

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a3
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: jruderman, Assigned: sdwilsh)

References

Details

(Keywords: regression, testcase)

Attachments

(1 file, 2 obsolete files)

v1.0
12.03 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached file testcase (dynamic) (obsolete) — 
Could this be a regression from bug 461199?
Attached file reference (static) (obsolete) — 

    
    

    
  
Er, this is the UnsetAttr version of bug 461199 part 30, looks like.  I thought I'd checked that.  :(

    
    

    
  
(In reply to comment #2)
> Er, this is the UnsetAttr version of bug 461199 part 30, looks like.  I thought
> I'd checked that.  :(
I thought we had too :/

Need to make the test check html:a, html:area, html:link, and svg:a.
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED
Component: Layout → DOM: Core & HTML
QA Contact: layout → general

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.0
        — 
          — Splinter Review
      

    


  
With tests.  I didn't quite use Jesse's test, but they did help identify the bug quickly!

        Attachment #429919 -
        Attachment is obsolete: true

        Attachment #429920 -
        Attachment is obsolete: true

        Attachment #430113 -
        Flags: review?(bzbarsky)

    
  
Whiteboard: [needs review bz]

    
  
Summary: Removing href attribute from <a> doesn't remove link styling → Removing href attribute from html:a, html:link, and svg:a doesn't remove link styling
Target Milestone: --- → mozilla1.9.3a3

        Attachment #430113 -
        Flags: review?(bzbarsky) → review+

    
  
Whiteboard: [needs review bz] → [can land]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/d3270b0acf47
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [can land]

    
    

    
  
And followup to enable a test that passes because this got fixed:
http://hg.mozilla.org/mozilla-central/rev/56b8a3bd290f

    
  
blocking2.0: ? → final+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: