549812 - small navigation buttons are too narrow

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Asa Dotzler [:asa]]

http://svn.mozilla.org/design/projects/newtheme/strata/i05/

The small icon buttons aren't as wide (by three pixels each) as they are in the mock-ups.

Tested with today's trunk build. 

The large back+forward combo matches the mock-up precisely.

Comment 1

[Asa Dotzler [:asa]]

Attachment: small buttons (bottom pair) don't match mock-up (top pair)

Comment 2

[Dão Gottwald [:dao]]

This is intentional, as per bug 547752. Small icons mode shouldn't just be a switch for the back button...

Comment 3

[Asa Dotzler [:asa]]

so the mock-ups are wrong? kind of hard to know how to test and file bugs on changes like this if the mocks aren't actually specs.

Comment 4

[Dão Gottwald [:dao]]

I don't know if it's intentional. (Stephen?) If it is intentional, I'm disagreeing with it.

Comment 5

[Dão Gottwald [:dao]]

Well, now my comments don't seem to make sense. It was intentional from my side. I don't know if it's intentionally different in the mockups.

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to comment #3)
> so the mock-ups are wrong? kind of hard to know how to test and file bugs on
> changes like this if the mocks aren't actually specs.

They are supposed to be "specs" so filing bugs based on the mockups/designs is correct.

After thinking about it I think Dao's approach here is better than the mockups. Initially the thinking was just to remove the large back button for some more vertical space savings and for people who wanted more consistent buttons.

Making the buttons a little more narrow and decreasing the spacing truly gives smaller buttons and more toolbar space.

Comment 7

[Asa Dotzler [:asa]]

OK. Thanks for the confirmation. Not a bug in Firefox. Do we need the specs to be updated? I'll go ahead and resolve this.