Closed Bug 549894 Opened 14 years ago Closed 14 years ago

crash stacks on Windows leak test broken (MINIDUMP_STACKWALK path translation problem)

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86
Windows Server 2003
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

Details

Attachments

(1 file)

toolsdir.diff
3.33 KB, patch
bhearsum
: review+
bhearsum
: feedback+
bhearsum
: checked-in+
Details | Diff | Splinter Review 
python leaktest.py -- -CreateProfile default --symbols-path ../dist/crashreporter-symbols
 in dir e:\builds\moz2_slave\mozilla-central-win32-debug\build/obj-firefox/_leaktest (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', 'leaktest.py', '--', '-CreateProfile', 'default', '--symbols-path', '../dist/crashreporter-symbols']
................
 environment:#
  MINIDUMP_STACKWALK=/e/builds/moz2_slave/mozilla-central-win32-debug/tools/breakpad/win32/minidump_stackwalk.exe
................

MINIDUMP_STACKWALK binary not found: /e/builds/moz2_slave/mozilla-central-win32-debug/tools/breakpad/win32/minidump_stackwalk.exe
......

See bug 522829 for fixes made for UnittestPackagedBuildFactory
Assignee: nobody → raliiev
Attached patch toolsdir.diff — — Splinter Review 
I have to patch MercurialBuildFactory, UnittestBuildFactory and CCUnittestBuildFactory because MozillaBuildFactory dosn't aware about platforms.
Attachment #431597 - Flags: feedback?(bhearsum)
Comment on attachment 431597 [details] [diff] [review]
toolsdir.diff

Makes sense to me. We already do exactly this in UnittestBuildFactory.
Attachment #431597 - Flags: review+
Attachment #431597 - Flags: feedback?(bhearsum)
Attachment #431597 - Flags: feedback+
Attachment #431597 - Flags: checked-in?
Comment on attachment 431597 [details] [diff] [review]
toolsdir.diff

changeset:   647:8dd45136d26b
Attachment #431597 - Flags: checked-in? → checked-in+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Actually, this isn't fixed yet, the buildbot masters aren't taking the update.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
okay, finally got the masters reconfigered
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: