549894 - crash stacks on Windows leak test broken (MINIDUMP_STACKWALK path translation problem)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

python leaktest.py -- -CreateProfile default --symbols-path ../dist/crashreporter-symbols
 in dir e:\builds\moz2_slave\mozilla-central-win32-debug\build/obj-firefox/_leaktest (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', 'leaktest.py', '--', '-CreateProfile', 'default', '--symbols-path', '../dist/crashreporter-symbols']
................
 environment:#
  MINIDUMP_STACKWALK=/e/builds/moz2_slave/mozilla-central-win32-debug/tools/breakpad/win32/minidump_stackwalk.exe
................

MINIDUMP_STACKWALK binary not found: /e/builds/moz2_slave/mozilla-central-win32-debug/tools/breakpad/win32/minidump_stackwalk.exe
......

See bug 522829 for fixes made for UnittestPackagedBuildFactory

Comment 1

[Rail Aliiev [:rail]]

Attachment: toolsdir.diff

I have to patch MercurialBuildFactory, UnittestBuildFactory and CCUnittestBuildFactory because MozillaBuildFactory dosn't aware about platforms.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 431597 [details] [diff] [review]
toolsdir.diff

Makes sense to me. We already do exactly this in UnittestBuildFactory.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 431597 [details] [diff] [review]
toolsdir.diff

changeset:   647:8dd45136d26b

Comment 4

[[e-mail] (:bhearsum)]

Actually, this isn't fixed yet, the buildbot masters aren't taking the update.

Comment 5

[[e-mail] (:bhearsum)]

okay, finally got the masters reconfigered