550107 - Don't export Spotlight metadata for menu spacers

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

They have no URLs and no useful name, so it's kinda stupid.

We should maybe consider not writing out metadata for javascript bookmarklets, since they'll do nothing, but on the other hand, if you're looking for something by name/name fragment, they do have useful names.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: fix

The code in this patch is from cl, who doesn't have a tree ATM.

Comment 2

[Chris Lawson (gone)]

Comment on attachment 431026 [details] [diff] [review]
fix

This seems simple enough for just an sr, but I'm happy to get an r if we want one.

Comment 3

[Stuart Morgan]

Comment on attachment 431026 [details] [diff] [review]
fix

I don't see any advantage to checking both in the method and at the call sites; just make the Bookmark.mm change and don't push the logic onto the callers.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: fix, v1.1

This is just the Bookmark.mm change from the last patch (from the "you poke it, you keep generating the patches" school of development ;) ).

Comment 5

[Stuart Morgan]

Comment on attachment 432225 [details] [diff] [review]
fix, v1.1

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Kind-of seems like something we could take for 2.0.3; it's not overtly harmful, but it does keep us from generating garbage.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on CAMINO_2_0_BRANCH for 2.0.3.