please initialize non static class members in all constructors and use mFoo notation

RESOLVED FIXED

Status

()

Core
Disability Access APIs
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
x86
All
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

8 years ago
This is sort of a meta bug. Coverity really is fairly annoyed by nsStateMapEntry and possibly other classes, I'll attach my list of complaints later.
(Assignee)

Comment 1

8 years ago
Created attachment 430292 [details]
coverity output

Updated

8 years ago
Blocks: 389800
(Assignee)

Comment 2

8 years ago
Created attachment 431871 [details] [diff] [review]
untested

i don't have an environment to test this, please confirm it compiles and does the right thing.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #431871 - Flags: review?(bolterbugz)
Created attachment 432190 [details] [diff] [review]
some minor fixups to timeless' patch

Thanks I made some minor tweaks. Alexander, can you give a quick nod to these changes? It makes code analysis tools happier.

(Note patch is from timeless)
Attachment #431871 - Attachment is obsolete: true
Attachment #432190 - Flags: review?(surkov.alexander)
Attachment #431871 - Flags: review?(bolterbugz)
Created attachment 432191 [details] [diff] [review]
some minor fixups to timeless' patch

Oops that was a diff... here is the patch with the right header info in case someone else ends up pushing this.
Attachment #432190 - Attachment is obsolete: true
Attachment #432191 - Flags: review?(surkov.alexander)
Attachment #432190 - Flags: review?(surkov.alexander)

Comment 5

8 years ago
Comment on attachment 432191 [details] [diff] [review]
some minor fixups to timeless' patch

fine with me
Attachment #432191 - Flags: review?(surkov.alexander) → review+
Keywords: checkin-needed
I didn't push earlier due to odd errors on try server. Trying again, will update the bug.
Try server ran okay. I can't push right now as I'll be AFK.
http://hg.mozilla.org/mozilla-central/rev/b0dfdfe31681
(Thanks timeless)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.