550180 - please initialize non static class members in all constructors and use mFoo notation

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[timeless]

This is sort of a meta bug. Coverity really is fairly annoyed by nsStateMapEntry and possibly other classes, I'll attach my list of complaints later.

Comment 1

[timeless]

Attachment: coverity output

Comment 2

[timeless]

Attachment: untested

i don't have an environment to test this, please confirm it compiles and does the right thing.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: some minor fixups to timeless' patch

Thanks I made some minor tweaks. Alexander, can you give a quick nod to these changes? It makes code analysis tools happier.

(Note patch is from timeless)

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: some minor fixups to timeless' patch

Oops that was a diff... here is the patch with the right header info in case someone else ends up pushing this.

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 432191 [details] [diff] [review]
some minor fixups to timeless' patch

fine with me

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

I didn't push earlier due to odd errors on try server. Trying again, will update the bug.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Try server ran okay. I can't push right now as I'll be AFK.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

http://hg.mozilla.org/mozilla-central/rev/b0dfdfe31681
(Thanks timeless)