Closed Bug 550180 Opened 10 years ago Closed 10 years ago

please initialize non static class members in all constructors and use mFoo notation

Categories

(Core :: Disability Access APIs, defect, minor)

x86
All
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 2 open bugs)

Details

(Keywords: coverity)

Attachments

(2 files, 2 obsolete files)

This is sort of a meta bug. Coverity really is fairly annoyed by nsStateMapEntry and possibly other classes, I'll attach my list of complaints later.
Attached file coverity output
Attached patch untested (obsolete) — Splinter Review
i don't have an environment to test this, please confirm it compiles and does the right thing.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #431871 - Flags: review?(bolterbugz)
Thanks I made some minor tweaks. Alexander, can you give a quick nod to these changes? It makes code analysis tools happier.

(Note patch is from timeless)
Attachment #431871 - Attachment is obsolete: true
Attachment #432190 - Flags: review?(surkov.alexander)
Attachment #431871 - Flags: review?(bolterbugz)
Oops that was a diff... here is the patch with the right header info in case someone else ends up pushing this.
Attachment #432190 - Attachment is obsolete: true
Attachment #432191 - Flags: review?(surkov.alexander)
Attachment #432190 - Flags: review?(surkov.alexander)
Comment on attachment 432191 [details] [diff] [review]
some minor fixups to timeless' patch

fine with me
Attachment #432191 - Flags: review?(surkov.alexander) → review+
I didn't push earlier due to odd errors on try server. Trying again, will update the bug.
Try server ran okay. I can't push right now as I'll be AFK.
http://hg.mozilla.org/mozilla-central/rev/b0dfdfe31681
(Thanks timeless)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.