550282 - Save As File Draft Message Dialogue Generates Incorrect Filenames

Status: NEW

(MailNews Core :: Composition, defect)

Description

[lord_alan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.8) Gecko/20100214 Ubuntu/9.10 (karmic) Firefox/3.5.8
Build Identifier: 20100302133342

Doing the downloading & saving litmus test for 3.1b1. All works as expected apart from the Save As filename doesn't get updated.

Create a draft message with a subject line of test 1. Save as File. And save.
Create a second draft message (in a different mail account (imap/pop etc) and give it a totally different subject line. When you choose Save As, the file dialogue contains the name of the first file with added character entities.


Reproducible: Always

Steps to Reproduce:
Create New Message:
Subject line "test message fir litmus-test"
First file name in save as dialogue: test%20message%20fir%20litmus-test.asc

Create a new message in another account: Subject line: "litmus test"
Second file name: test%2520message%2520fir%2520litmus-test.asc

Third new message in another account: Subject line: "Big Test"
Third file name: test%252520message%252520fir%252520litmus-test.asc


Expected Results:  
The Save As dialogue box should contain a name related to what is in the Subject line of the message being saved. Not the last message.

The filename in the dialogue box is editable of course, but this just seems wrong.

Comment 1

[Nathan Tuggy (:tuggyne)]

Reproduced with a bit of difficulty on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.2pre) Gecko/20100302 Lanikai/3.1b1.
First time I tried this, I had a colon in my subjects, and nothing interesting happened: the files saved just like normal, no percent-encodings, no nothing.
Then I sent one of the drafts (I believe from the compose window that was still open, but I may have closed, accepted draft save, and reopened to send).
After this I was able to reproduce it nicely several times.
Then I restarted Lanikai.
I sent a message (without first saving it as a draft or a draft file, except for the auto-saves).
I saved another message as draft and file, and it behaved normally.
The next message though exhibited the bug again on save.

Seemingly to reproduce this you must send a message and save a draft as a file and in the Drafts folder; Lanikai will then exhibit this bug until you restart.

So my STR:
0. Start Lanikai fresh (restarting if necessary)
1. Create message 1 (subject: `BzT - Draft Save 1 of 3` without backquotes)
2. Send message 1
3. Create message 2 (`BzT - Draft Save 2 of 3`)
4. Save message 2 as a draft file with the default name
5. Close message 2; at the save prompt, choose to save the draft
6. Create message 3 (`BzT - Draft Save 3 of 3`)
7. Begin saving message 3 as a draft file

Expected:
Filename in field of `BzT - Draft Save 3 of 3.txt` (on Windows) or `BzT - Draft Save 3 of 3.asc` (on Linux)

Actual:
Filename is `BzT%20-%20Draft%20Save%202%20of%202.txt` -- i.e., percent-encoded

Also, I got the following messages (not warnings or errors, messages) in the Error Console:
Security Error: Content at about:blank may not load or link to file:///C:/Users/Nathan/Documents/System/Bugzilla/BzT%20-%20Draft%20Save%202%20of%203.txt.
Security Error: Content at about:blank may not load or link to file:///C:/Users/Nathan/Documents/System/Bugzilla/BzT%2520-%2520Draft%2520Save%25202%2520of%25203.txt.

I used a single IMAP account for this, with emails addressed to myself. (Verified that I was able to reproduce once more, in Safe Mode, by precisely following the STR above.)

I doubt that this is exploitable in any way, but the security errors give me pause.