Closed Bug 550305 Opened 13 years ago Closed 13 years ago

Reduce round-trips by making some methods with no return values async

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

Fewer roundtrips for PluginScriptableObject stuff, rev. 1
12.88 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review 
Currently the following methods are rpc but I don't think they need to be:
PPluginInstance.PPluginScriptableObject (constructor)
PPluginScriptableObject.Protect
PPluginScriptableObject.Unprotect
PPluginScriptableObject.__delete__

Making these async means that there are fewer roundtrips (sometimes many fewer roundtrips!) between the two processes when doing some types of NPRuntime scripting.

        Attachment #430409 -
        Flags: review?(bent.mozilla)

    
    

    
  
Comment on attachment 430409 [details] [diff] [review]
Fewer roundtrips for PluginScriptableObject stuff, rev. 1

Oh man, this makes me nervous... Do tests pass with this?

        Attachment #430409 -
        Flags: review?(bent.mozilla) → review+

    
    

    
  
Yes... it doesn't seem especially risky to me, since IPDL guarantees that async messages will be delivered before RPC reply messages.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/32383f6674e6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.