Closed
Bug 550305
Opened 15 years ago
Closed 15 years ago
Reduce round-trips by making some methods with no return values async
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
12.88 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Currently the following methods are rpc but I don't think they need to be:
PPluginInstance.PPluginScriptableObject (constructor)
PPluginScriptableObject.Protect
PPluginScriptableObject.Unprotect
PPluginScriptableObject.__delete__
Making these async means that there are fewer roundtrips (sometimes many fewer roundtrips!) between the two processes when doing some types of NPRuntime scripting.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #430409 -
Flags: review?(bent.mozilla)
Comment on attachment 430409 [details] [diff] [review]
Fewer roundtrips for PluginScriptableObject stuff, rev. 1
Oh man, this makes me nervous... Do tests pass with this?
Attachment #430409 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Yes... it doesn't seem especially risky to me, since IPDL guarantees that async messages will be delivered before RPC reply messages.
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•