550402 - Property readonly bit interferes with setter functions in properties

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Per ES5 the readonly bit should be meaningless for accessor descriptors.  This is one of a few problems with how js_SetPropertyHelper works compared to what ES5 requires, if memory serves -- will get to this soon.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

There's likely more ES-conforming cleanup here, but one step at a time.  I need this for the patch to remove old-style getters/setters (which don't incidentally set the readonly bit in accessor descriptors, while Object.defineProperty does), so this is all I'm doing for now.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 436728 [details] [diff] [review]
Patch

Looks good! Please also tidy up the one remaining use of the read_only_error label. r=me with that.

Comment 3

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/53e381fe0f8b

Still the one followup to fix (and the problem is reasonably clear in hindsight), but beyond that I think we're good here.

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/53e381fe0f8b